Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3141 #1

Open
wants to merge 89 commits into
base: master
Choose a base branch
from
Open

Issue 3141 #1

wants to merge 89 commits into from

Conversation

Twizty
Copy link

@Twizty Twizty commented Nov 15, 2019

No description provided.

alexandru and others added 30 commits April 23, 2018 10:50
@alexandru
Enhance EitherT and fix typelevel#2161: add MonadError.redeem/redeemWith
3457276
@barambani
Added combineAllOption to Foldable
e3bd620
@barambani
Attempt
94fcff1
@tkroman
Added separateFoldable
7600623
@tkroman
format
c703e70
@tkroman
scalafmt
23e8a28
@tkroman
syntax
dd02f8e
@tkroman
syntax test
ebde934
@tkroman
syntax test
8ba46a3
@tkroman
syntax test
d7463af
@tkroman
syntax in a separate class
d9990ad
@gheine
NonEmptyChain.fromSeq should take scala.collection.Seq instead of sca…
e5372d0 
…la.collection.immutable.Seq

Similar to Chain.fromSeq()
@barambani
Merge branch 'master' into issue-2363
7f252c7
@barambani
prePR
7f8e044
@gheine
Merge remote-tracking branch 'upstream/master'
2c60919
@barambani
Merge branch 'master' into issue-2363
200d9c0
@travisbrown
Merge branch 'master' into topic/nec-fromSeq
2e4f67f
@travisbrown
Fix bincompat
82eebee
@barambani
Added overrides for iterator, adapted tests, deprecated Stream
654aae5
@barambani
Removed tc iterator and changed with LazyList for 2.13 and Stream for
64053b5 
2.12
@barambani
Restored original iterator in tests, added iterable syntax and test
427c7f5
@barambani
Removed override non needed, refined tests
38cbe68
@barambani
Implemented fold in terms of iterable
f951eef
@barambani
Changed to Iterable
2d835f1
@tkroman
Update alternative.scala
a210efe
@tkroman
Update alternative.scala
f0b982c
@tkroman
Merge branch 'master' of github.com:typelevel/cats into separateFoldable
0f76a76
@travisbrown
Revert non-redeem parts of 3457276
2f42f4e
@travisbrown
Merge branch 'master' into topic/add-redeem
69c5650
@travisbrown
Move redeem to ApplicativeError
a8ca542
@mnesvit
Copy link
Member

mnesvit commented Nov 15, 2019

I think we can squash the commits

svitkovsergey
svitkovsergey approved these changes Nov 15, 2019
View reviewed changes
Copy link

@svitkovsergey svitkovsergey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Twizty and others added 7 commits November 15, 2019 18:38
@Twizty
typelevel#3141 Fixed docs
07f8d38
@travisbrown
Merge pull request typelevel#3154 from travisbrown/topic/1.x-deprecat…
4563806 
…ions

Make 1.x deprecation targets package-private
@travisbrown
Merge pull request typelevel#3152 from travisbrown/topic/type-class-m…
291af38 
…ethods

"Move" type class syntax methods onto type classes
@travisbrown @rossabaker
2.1.0-RC1 follow-up (typelevel#3157)
8867e97 
* Setting version to 2.1.0-RC1

* Setting version to 2.1.0-SNAPSHOT

* Update contributors for 2.1.0-RC1

* Update changelog for 2.1.0-RC1

* Add 2.1.0-RC1 announcement
@Twizty
Merge branch 'master' into issue3141
971f380
@Twizty
typelevel#3141 Formatted
d59858a
@Twizty
typelevel#3141 Refactored
619b1b4
@myazinn
Copy link

myazinn commented Nov 18, 2019 •
edited
Loading

Is everything ok with this PR? I assume it contains too many commits.

@svitkovsergey
Copy link

@myazinn
as @Twizty said on a daily meeting today, typelevel are squashing commits by themselves before merging, so I think everything is fine.

@Mikhail-Sosnin
Copy link

@Twizty Please, take care of commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svitkovsergey svitkovsergey svitkovsergey approved these changes

@mnesvit mnesvit mnesvit approved these changes

@AlekseiLitkovetc AlekseiLitkovetc Awaiting requested review from AlekseiLitkovetc

@hope-doe hope-doe Awaiting requested review from hope-doe

@DenisVerkhoturov DenisVerkhoturov Awaiting requested review from DenisVerkhoturov

@iliaonishchenko iliaonishchenko Awaiting requested review from iliaonishchenko

@Mikhail-Sosnin Mikhail-Sosnin Awaiting requested review from Mikhail-Sosnin

@myazinn myazinn Awaiting requested review from myazinn

@SergeiIonin SergeiIonin Awaiting requested review from SergeiIonin

@SergeySdv SergeySdv Awaiting requested review from SergeySdv

@timaliberdov timaliberdov Awaiting requested review from timaliberdov

@TimurKustov TimurKustov Awaiting requested review from TimurKustov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.