fix: add alternate expected output for Linux and Windows - #73
Open
zainedb wants to merge 1 commit into
Open
Conversation
The regression suite's expected/system_stats.out was written on macOS. Linux and Windows each populate different subsets of system-info columns, causing installcheck to fail on those platforms. Add pg_regress alternate expected output files so the suite passes on all three platforms without external patches: - system_stats_1.out: Linux (handle_count, thread_count, clock_speed populated; logical_processors reports 0 in containers) - system_stats_2.out: Windows (no swap_total, no usermode/kernelmode CPU usage, no sleeping/zombie process states)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expected/system_stats.outwas written on macOS. Linux and Windows populate different subsets of system-info columns, causingmake installcheckto fail on those platforms.expected/system_stats_1.out(Linux) andexpected/system_stats_2.out(Windows) as pg_regress alternate expected output files, so the suite passes on all three platforms natively.Platform differences
handle_countthread_countlogical_processorsclock_speedswap_totalusermode/kernelmodeio_validsleeping/zombieTest plan
make installcheckon macOS — should matchsystem_stats.outmake installcheckon Linux — should matchsystem_stats_1.outmake installcheckon Windows — should matchsystem_stats_2.out