Skip to content

Fix regression test - #71

Open
devrimgunduz wants to merge 1 commit into
EnterpriseDB:masterfrom
devrimgunduz:master
Open

Fix regression test#71
devrimgunduz wants to merge 1 commit into
EnterpriseDB:masterfrom
devrimgunduz:master

Conversation

@devrimgunduz

Copy link
Copy Markdown

This small patch fixes the only failing regression test. Not sure if it is the right fix or not though.

Per: pgdg-packaging/pgdg-rpms#213

@tureba

tureba commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

On a cursory look, the change appears ok. However, I think the reason why this wasn't noticed by me when I proposed the addition of the tests to begin with is because the outputs may differ depending on the OS, and my tests might not have covered the same as yours. If so, applying it may cause tests to fail elsewhere.

It is important that we build and run the tests across all our supported platforms, including macOS and Windows, and check where they succeed and fail.

Because if they all fail with regression.diffs similar to this PR proposal, then the PR may be applied as is. But if some succeed, then we should change the proposal so that instead of it changing expected/system_stats.out, it would add a expected/system_stats_1.out, to account for the alternate expected output.

@neel5481 , @zainedb , @agarwal-kritika I see you are all involved with the development of this, including the workflows that build and test it. We must make sure that the workflows that build all our packages also test them, and only upload to cloudsmith if the tests pass. Whatever tests fail will be input to deciding what to do with this PR.

@tureba
tureba requested a review from neel5481 August 12, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants