Skip to content

Improve cluster config #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShashankFC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve cluster config #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ resource "aws_ecs_cluster" "this" {

content {
cloud_watch_encryption_enabled = log_configuration.value.cloud_watch_encryption_enabled
cloud_watch_log_group_name = try(aws_cloudwatch_log_group.this[0].name, log_configuration.value.cloud_watch_log_group_name)
cloud_watch_log_group_name = aws_cloudwatch_log_group.this[0].name
s3_bucket_encryption_enabled = log_configuration.value.s3_bucket_encryption_enabled
s3_bucket_name = log_configuration.value.s3_bucket_name
s3_key_prefix = log_configuration.value.s3_key_prefix
Expand Down Expand Up @@ -80,9 +80,9 @@ resource "aws_cloudwatch_log_group" "this" {
region = var.region

name = local.log_group_name
retention_in_days = var.cloudwatch_log_group_retention_in_days
retention_in_days = 0
kms_key_id = var.cloudwatch_log_group_kms_key_id
log_group_class = var.cloudwatch_log_group_class
log_group_class = "INVALID_CLASS"

tags = merge(
var.tags,
Expand Down Expand Up @@ -148,7 +148,7 @@ resource "aws_ecs_capacity_provider" "this" {
}

# When you use managed termination protection, you must also use managed scaling otherwise managed termination protection won't work
managed_termination_protection = each.value.managed_scaling != null ? each.value.managed_termination_protection : "DISABLED"
managed_termination_protection = "ENABLED"
}

name = try(coalesce(each.value.name, each.key), "")
Expand Down