Skip to content

Image fixes for 116#959

Open
TamaraNaboulsi wants to merge 3 commits into
postreleasefix/116from
image_fixes
Open

Image fixes for 116#959
TamaraNaboulsi wants to merge 3 commits into
postreleasefix/116from
image_fixes

Conversation

@TamaraNaboulsi
Copy link
Copy Markdown
Member

Following PR #956, it turned out that image names need to be exactly like species names, which are capitalized. This PR fixes that. In addition, some image names for species with GCA in the name needed fixing to also match the species name.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a Great Dane on the updated image :-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! @EreboPSilva could you advise on which image to use here? As the new image was part of your PR #956

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image cropped incorrectly?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it. @EreboPSilva could you also advise on this please?

@twalsh-ebi
Copy link
Copy Markdown
Contributor

Hi @TamaraNaboulsi .. Thanks for this update. I can now see species images for all Pig genomes except Sus scrofa domesticus breed Meishan GCA_017957985.1, which seems to be expecting a file at: ensembl/htdocs/i/species/Sus_scrofa_domesticus_GCA_017957985.1.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants