fix: rename duplicated function name and add missing route tests#89
Open
Aadik1ng wants to merge 1 commit into
Open
fix: rename duplicated function name and add missing route tests#89Aadik1ng wants to merge 1 commit into
Aadik1ng wants to merge 1 commit into
Conversation
- Renamed duplicated 'get_genome_ftplinks' to 'get_region_checksum' - Added basic test cases for checksum and VEP file paths routes to verify mapping - Re-formatted files with Black
3 tasks
Author
|
@andrewyatz please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a copy-paste error in
app/api/resources/metadata.pywhere the function nameget_genome_ftplinkswas mistakenly reused across two different routes.The function associated with the region checksum route has been renamed to
get_region_checksumto align with its decorator and intended functionality.Changes Made
get_region_checksumfor:test_metadata.py:test_region_checksum_routeensures the checksum route responds correctly (even if gRPC is unavailable), preventing silent 404stest_vep_file_paths_routeverifies correct route mapping for VEP file pathsRoute Fix
GET /genome/{genome_uuid}/checksum/{region_name}now correctly maps toget_region_checksum(previously incorrectly mapped toget_genome_ftplinks)Testing
Checklist