feat: end-to-end webhook monitoring with Horizon SSE (#94/#61)#369
Open
udeachudivine-spec wants to merge 1 commit into
Open
feat: end-to-end webhook monitoring with Horizon SSE (#94/#61)#369udeachudivine-spec wants to merge 1 commit into
udeachudivine-spec wants to merge 1 commit into
Conversation
…mmy123222#61) - Split monolithic webhookService.js into three focused modules: webhookStore.js (in-memory Map store), webhookDelivery.js (signed POST delivery), paymentMonitor.js (Horizon SSE streaming) - Fix Promise.allSettled for parallel webhook delivery so one slow/ failing endpoint never blocks others - Add idempotent ensureMonitored() guard to prevent duplicate SSE streams on re-registration for the same public key - Add resumeAllMonitors() called at server startup so existing webhooks survive restarts - Fix HMAC signature header: X-Stellar-Signature: sha256=<hex> and add X-Webhook-ID header; reuse utils/webhookSignature.js - Fix payload: event name payment_received, add transactionHash and ledger fields - Fix POST /api/webhooks: validate publicKey via StrKey, enforce https:// URL, strip secret from response - Fix GET /api/webhooks/:publicKey: return { webhooks: [...] } - Fix DELETE /api/webhooks/:id: return { success: true } / 404 - webhookService.js kept as compat facade re-exporting all symbols
|
@udeachudivine-spec is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split monolithic webhookService.js into three focused modules: webhookStore.js (in-memory Map store), webhookDelivery.js (signed POST delivery), paymentMonitor.js (Horizon SSE streaming)
Fix Promise.allSettled for parallel webhook delivery so one slow/ failing endpoint never blocks others
Add idempotent ensureMonitored() guard to prevent duplicate SSE streams on re-registration for the same public key
Add resumeAllMonitors() called at server startup so existing webhooks survive restarts
Fix HMAC signature header: X-Stellar-Signature: sha256=
and add X-Webhook-ID header; reuse utils/webhookSignature.js
Fix payload: event name payment_received, add transactionHash and ledger fields
Fix POST /api/webhooks: validate publicKey via StrKey, enforce https:// URL, strip secret from response
Fix GET /api/webhooks/:publicKey: return { webhooks: [...] }
Fix DELETE /api/webhooks/:id: return { success: true } / 404
webhookService.js kept as compat facade re-exporting all symbols
Summary
Type of change
Related issue
Closes #
Changes
Testing
Screenshots (if UI change)
Checklist
main