Skip to content

feat: add fallback textarea in noscript #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilePerron merged 1 commit into from
Feb 11, 2025
Merged

feat: add fallback textarea in noscript #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions templates/form/tinymce_type.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,12 @@
>{{ value }}</tinymce-editor>
<script src="{{ asset('bundles/tinymce/default-tinymce-config.js') }}" type="module"></script>
<script src="{{ asset('bundles/tinymce/ext/tinymce-webcomponent.js') }}" type="module"></script>
<noscript>
<textarea id="{{ id }}-noscript"
name="{{ full_name }}"
{{ required ? "required" : "" }}
{% with { attr: tinymce_attributes(attr) } %}
{{ block('attributes') }}
{% endwith %}>{{ value }}</textarea>
</noscript>
{%- endblock -%}
20 changes: 20 additions & 0 deletions tests/e2e/tests-noscript.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { test, expect } from '@playwright/test';
test.use({ javaScriptEnabled: false });

test.describe('Without Javascript', () => {
test('Form type', async ({ page }) => {
await page.goto('http://localhost/test/form');

const textarea = page.getByRole('textbox').getByText('Initial text value');

// Validate fallback textarea is present and has initial content
await expect(textarea).toBeVisible();
await expect(textarea).toHaveValue('<p>Initial text value</p>');
// Update the content and submit the form
await textarea.fill('Initial text value has been updated!');
await page.getByRole('button', { name: 'Submit' }).click();

// Validate form data is received correctly
await expect(page.getByText('Initial text value has been updated!')).toBeVisible();
});
});
64 changes: 33 additions & 31 deletions tests/e2e/tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,49 @@
import { test, expect } from '@playwright/test';

test('Form type', async ({ page }) => {
await page.goto('http://localhost/test/form');
test.describe('With Javascript', () => {
test('Form type', async ({ page }) => {
await page.goto('http://localhost/test/form');

// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();
// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();

// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();
// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();

// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();
// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();

// Update the content and submit the form
await page.frameLocator('iframe[title="Rich Text Area"]').getByLabel('Rich Text Area. Press ALT-0').fill('Initial text value has been updated!');
await page.getByRole('button', { name: 'Submit' }).click();
// Update the content and submit the form
await page.frameLocator('iframe[title="Rich Text Area"]').getByLabel('Rich Text Area. Press ALT-0').fill('Initial text value has been updated!');
await page.getByRole('button', { name: 'Submit' }).click();

// Validate form data is received correctly
await expect(page.getByText('Initial text value has been updated!')).toBeVisible();
});
// Validate form data is received correctly
await expect(page.getByText('Initial text value has been updated!')).toBeVisible();
});

test('Template', async ({ page }) => {
await page.goto('http://localhost/test/template');
test('Template', async ({ page }) => {
await page.goto('http://localhost/test/template');

// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();
// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();

// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();
// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();

// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();
});
// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();
});

test('Javascript', async ({ page }) => {
await page.goto('http://localhost/test/javascript');
test('Javascript', async ({ page }) => {
await page.goto('http://localhost/test/javascript');

// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();
// Validate initial content
await expect(page.frameLocator('iframe[title="Rich Text Area"]').getByText('Initial text value')).toBeVisible();

// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();
// Validate YAML configuration-provided attribute
await expect(page.getByLabel('Bold')).toBeVisible();

// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();
// Validate user-provided attribute
await expect(page.locator('button').filter({ hasText: 'Format' })).toBeVisible();
});
});
Loading