Skip to content

Conversation

@dretay
Copy link

@dretay dretay commented Mar 16, 2020

Hi Andrzej,

Here's a cleaned up version that merges cleanly.... looks like there is some issue with one of your recent updates that's caused the time updates to not get sent correctly from the Jupyter notebook... i'll look into that tonight.

@Emeryth
Copy link
Owner

Emeryth commented Mar 17, 2020

Good job, thanks for contributing to this project.

One thing I am concerned about is that you're not supposed to distribute the Nordic SDK.
See https://devzone.nordicsemi.com/f/nordic-q-a/19187/how-to-license-code-based-off-of-examples-that-come-with-nordic-sdk-8-1/74304#74304
You should download it from their server instead.

looks like there is some issue with one of your recent updates that's caused the time updates to not get sent correctly from the Jupyter notebook... i'll look into that tonight.

The firmware now enforces secure pairing, is that the problem?

@dretay
Copy link
Author

dretay commented Mar 17, 2020

Good catch, never knew that. I refactored this to download the nRF5 lib from nordic's website. While I was in there i created dependency target to also initialize the submodules and the pipenv in one go... so the install instructions would be "make dependencies && make"

Yah i need to noodle on how to get bluez to do secure pairing... even on the command line I'm having issues... maybe that could be flagged so there's an insecure "dev" build thats easier / more convenient to test?


memset(&attr_md, 0, sizeof(attr_md));

#if defined(INSECURE_PAIRING) && INSECURE_PAIRING == 1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emeryth something like this: when you normally compile this will default to secure pairing... but if you build like INSECURE_PAIRING=1 make it will use mode_set_open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants