-
Notifications
You must be signed in to change notification settings - Fork 17
Refactored make #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Good job, thanks for contributing to this project. One thing I am concerned about is that you're not supposed to distribute the Nordic SDK.
The firmware now enforces secure pairing, is that the problem? |
|
Good catch, never knew that. I refactored this to download the nRF5 lib from nordic's website. While I was in there i created dependency target to also initialize the submodules and the pipenv in one go... so the install instructions would be "make dependencies && make" Yah i need to noodle on how to get bluez to do secure pairing... even on the command line I'm having issues... maybe that could be flagged so there's an insecure "dev" build thats easier / more convenient to test? |
|
|
||
| memset(&attr_md, 0, sizeof(attr_md)); | ||
|
|
||
| #if defined(INSECURE_PAIRING) && INSECURE_PAIRING == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Emeryth something like this: when you normally compile this will default to secure pairing... but if you build like INSECURE_PAIRING=1 make it will use mode_set_open
Hi Andrzej,
Here's a cleaned up version that merges cleanly.... looks like there is some issue with one of your recent updates that's caused the time updates to not get sent correctly from the Jupyter notebook... i'll look into that tonight.