use the device id to create a unique ble identifier#16
Open
x29a wants to merge 3 commits intoEmeryth:masterfrom
Open
use the device id to create a unique ble identifier#16x29a wants to merge 3 commits intoEmeryth:masterfrom
x29a wants to merge 3 commits intoEmeryth:masterfrom
Conversation
Author
|
After more investigation, i found the default advertising name size to be 31, so that should be more than enough? The error i get is NRF_ERROR_INVALID_PARAM. The strlen of the new name returns 22, so that would be <31. |
Author
|
Ok, looks like a classical fail. Defined the buffer too small (22 is greater than the 15 after all). Now all 8 bytes of the Device ID are used so the BLE device name might be something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently this creates an exception on bootup, i assume the device id is to long. when only using one byte as suffix, it works.
Any ideas?
This change requires a new build of GB as described here: Emeryth/Gadgetbridge#2 or included in the upstream PR.