Skip to content

drive: static_assert that struct Log stays all-float #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eugenevinitsky wants to merge 1 commit into from
Closed

drive: static_assert that struct Log stays all-float #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pufferlib/ocean/drive/drive.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,13 @@ typedef struct GridMapEntity GridMapEntity;
typedef struct GridMap GridMap;
typedef struct MapCacheEntry MapCacheEntry;

// Every field must be float. env_binding.h's vec_log iterates this struct as
// a raw float[] (sizeof(Log)/sizeof(float) entries), so a non-float field
// would be silently type-punned. When adding a field, also bump
// LOG_NUM_FLOAT_FIELDS below; the _Static_assert catches size mismatches
// from a forgotten bump or from a wider-than-float field (double/pointer).
#define LOG_NUM_FLOAT_FIELDS 54

struct Log {
float n;
float episode_return;
Expand Down Expand Up @@ -280,6 +287,11 @@ struct Log {
float reward_overspeed;
float reward_ade;
};
_Static_assert(
sizeof(struct Log) == LOG_NUM_FLOAT_FIELDS * sizeof(float),
"struct Log size mismatch: a field was added without bumping "
"LOG_NUM_FLOAT_FIELDS, or a non-float field slipped in (would corrupt "
"vec_log's raw-float iteration).");

struct GridMapEntity {
int entity_idx; // Index into the road_elements array
Expand Down
Loading