fix: Prevent potential panic when extracting x_token from URL#179
Open
zkpepe wants to merge 1 commit intoEllipsis-Labs:masterfrom
Open
fix: Prevent potential panic when extracting x_token from URL#179zkpepe wants to merge 1 commit intoEllipsis-Labs:masterfrom
x_token from URL#179zkpepe wants to merge 1 commit intoEllipsis-Labs:masterfrom
Conversation
Signed-off-by: zkpepe <shim.growers_6u@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed a potential issue in the
x_tokenextraction logic. If the provided URL doesn’t contain a/, the.pop().unwrap()call could cause a panic.To prevent this, I replaced
url.split('/')withurl.rsplitn(2, '/')and added a check to ensure we have enough parts before attempting to extractx_token.Now, if the URL format is invalid, the code returns an error instead of panicking.