Add presence for CQC #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libewa
reviewed
Aug 10, 2024
| game_version = 'in Odyssey' | ||
|
|
||
| elif not state['Horizons'] and not state['Odyssey']: | ||
| game_version = 'in Arena standalone' # or in pre horizons elite but who play it now |
There was a problem hiding this comment.
maybe change this to say "in Legacy Arena"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
It utilizes EDMC new (since release 5.2.0) plugin callback function
journal_entry_cqc. I've done this patch about 10 Aug 2021 but only now PRing it. I'm not sure if code satisfies general plugin's code style, it may be worth to wrap text on translations, for example. Any advices, remarks, critique are welcome.