[feature/concurrent-reads] Merge to develop#61
Merged
Conversation
- Wrap File in Mutex for thread-safe positioned reads - Wrap block_cache in Mutex for thread-safe LRU updates - Change get() and scan() from &mut self to &self - Add comprehensive concurrency tests: - test_concurrent_reads_same_keys - test_concurrent_reads_different_keys - test_concurrent_reads_with_cache_contention - test_concurrent_readers_shared_cache - Use parking_lot for faster Mutex implementation - Maintain backward compatibility with existing tests - Add documentation for thread-safety guarantees
GlobalBlockCache already has internal Mutex for thread-safety, so we don't need to wrap it again. This simplifies the code and avoids unnecessary clone operations.
The benchmark file doesn't exist, causing build failures. Removing the [[bench]] section until benchmarks are implemented.
- Change serde_core alias to serde (code expects 'serde') - Add serde_json for JSON serialization - Add tracing for logging - Fix edition to 2021 (let chains require 2024)
Let chains are only available in Rust 2024. Using nested if statements for compatibility with Rust 2021 edition.
- Add [features] section with 'api' feature flag - Add tracing_subscriber for logging initialization - Make api feature default for server binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated PR
✅ Build: Passed
✅ Tests: Passed
📊 Details
feature/concurrent-readsceb620e9f08c6fbf2041ee933e83aac7496f8cb0📝 Recent Commits
This PR was automatically created by the feature-fix-workflow