Skip to content

Conversation

@Eliav2
Copy link
Owner

@Eliav2 Eliav2 commented Nov 15, 2025

Note

Pins React, React DOM, and type packages to ~19.1 across the workspace and removes React 19.2-specific Activity usage from OverflowList.

  • Dependencies:
    • Pin react, react-dom, @types/react, @types/react-dom to ~19.1.0 via workspace catalog and lockfile; propagate to Radix UI, Storybook, vike, and related peer/dep graphs.
  • Components:
    • src/components/OverflowList.tsx: Remove fallback to React 19.2 Activity component; item visibility now returns null when not visible.

Written by Cursor Bugbot for commit d6f88ee. This will update automatically on new commits. Configure here.

@codesandbox
Copy link

codesandbox bot commented Nov 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Nov 15, 2025

Deploy Preview for react-responsive-overflow-list ready!

Name Link
🔨 Latest commit bd8b5c5
🔍 Latest deploy log https://app.netlify.com/projects/react-responsive-overflow-list/deploys/692d72a9290bfd22556847d2
😎 Deploy Preview https://deploy-preview-8--react-responsive-overflow-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 24

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Orphaned Type Definition Causes Version Conflicts

The @types/[email protected] package definition is still present in the lockfile despite being removed from the catalog. This causes a version mismatch where @types/[email protected] depends on @types/[email protected] (line 1802), but @types/[email protected] still references the old @types/[email protected] (line 1797). This orphaned type definition creates an inconsistent dependency graph that could lead to type conflicts or build failures when TypeScript tries to reconcile incompatible React type versions.

pnpm-lock.yaml#L1809-L1810

Fix in Cursor Fix in Web


Bug: Monorepo React Version Inconsistency

The demo/src/issues/4 workspace package has [email protected] and [email protected] installed, but this conflicts with the PR intent to downgrade to 19.1. While the package.json allows ^19.1.1 (permitting 19.2.0), the catalog specifies ~19.1.0 and all other workspace packages use 19.1.1. This creates an inconsistent React version across the monorepo where one package uses 19.2.0 while others use 19.1.1, potentially causing peer dependency warnings and runtime issues from mixing React versions.

pnpm-lock.yaml#L142-L150

demo/src/issues/4:
dependencies:
react:
specifier: ^19.1.1
version: 19.2.0
react-dom:
specifier: ^19.1.1
version: 19.2.0([email protected])

Fix in Cursor Fix in Web


Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 24

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: React 19.2+ Performance Regression

Removing the React.Activity feature support breaks functionality for React 19.2+ users. The removed code was backward compatible (checking React?.Activity existence before use), so it worked correctly on both React 19.1 and 19.2. Now users on React 19.2+ lose the mounting optimization that keeps overflowed items mounted while controlling visibility, forcing unnecessary unmounts during measurement phase.

src/components/OverflowList.tsx#L230-L234

const finalRenderItemVisibility =
renderItemVisibility ??
((node, meta) => {
if (!meta.visible) return null;
return <React.Fragment key={meta.index}>{node}</React.Fragment>;

Fix in Cursor Fix in Web


@Eliav2
Copy link
Owner Author

Eliav2 commented Nov 16, 2025

closing as its just for demo for possible react bug

@Eliav2 Eliav2 closed this Nov 16, 2025
@Eliav2 Eliav2 reopened this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants