-
Notifications
You must be signed in to change notification settings - Fork 0
change react demo to 19.1 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for react-responsive-overflow-list ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 24
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Orphaned Type Definition Causes Version Conflicts
The @types/[email protected] package definition is still present in the lockfile despite being removed from the catalog. This causes a version mismatch where @types/[email protected] depends on @types/[email protected] (line 1802), but @types/[email protected] still references the old @types/[email protected] (line 1797). This orphaned type definition creates an inconsistent dependency graph that could lead to type conflicts or build failures when TypeScript tries to reconcile incompatible React type versions.
pnpm-lock.yaml#L1809-L1810
react-responsive-overflow-list/pnpm-lock.yaml
Lines 1809 to 1810 in 2ace6c2
| '@types/[email protected]': |
Bug: Monorepo React Version Inconsistency
The demo/src/issues/4 workspace package has [email protected] and [email protected] installed, but this conflicts with the PR intent to downgrade to 19.1. While the package.json allows ^19.1.1 (permitting 19.2.0), the catalog specifies ~19.1.0 and all other workspace packages use 19.1.1. This creates an inconsistent React version across the monorepo where one package uses 19.2.0 while others use 19.1.1, potentially causing peer dependency warnings and runtime issues from mixing React versions.
pnpm-lock.yaml#L142-L150
react-responsive-overflow-list/pnpm-lock.yaml
Lines 142 to 150 in 2ace6c2
| demo/src/issues/4: | |
| dependencies: | |
| react: | |
| specifier: ^19.1.1 | |
| version: 19.2.0 | |
| react-dom: | |
| specifier: ^19.1.1 | |
| version: 19.2.0([email protected]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 24
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: React 19.2+ Performance Regression
Removing the React.Activity feature support breaks functionality for React 19.2+ users. The removed code was backward compatible (checking React?.Activity existence before use), so it worked correctly on both React 19.1 and 19.2. Now users on React 19.2+ lose the mounting optimization that keeps overflowed items mounted while controlling visibility, forcing unnecessary unmounts during measurement phase.
src/components/OverflowList.tsx#L230-L234
react-responsive-overflow-list/src/components/OverflowList.tsx
Lines 230 to 234 in d6f88ee
| const finalRenderItemVisibility = | |
| renderItemVisibility ?? | |
| ((node, meta) => { | |
| if (!meta.visible) return null; | |
| return <React.Fragment key={meta.index}>{node}</React.Fragment>; |
|
closing as its just for demo for possible react bug |
Note
Pins React, React DOM, and type packages to ~19.1 across the workspace and removes React 19.2-specific Activity usage from OverflowList.
react,react-dom,@types/react,@types/react-domto~19.1.0via workspace catalog and lockfile; propagate to Radix UI, Storybook, vike, and related peer/dep graphs.src/components/OverflowList.tsx: Remove fallback to React 19.2Activitycomponent; item visibility now returnsnullwhen not visible.Written by Cursor Bugbot for commit d6f88ee. This will update automatically on new commits. Configure here.