Repository navigation
Respect TensorRT-LLM input limits during generation - #4408
Open
sdivyanshu90 wants to merge 1 commit into
Open
sdivyanshu90 wants to merge 1 commit into
sdivyanshu90 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @baberabb, could you please review this PR whenever you have some time. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRT-LLM generation currently borrows unused output capacity for prompts, so an engine configured with max_input_len=2048 can receive 2304 input tokens. Include the separate engine input cap in the truncation budget while retaining the total sequence cap, requested generation length, and truncation direction.
Add CPU tests using the real constructor and generate_until with a recording engine, covering all three truncation directions, short/boundary/long prompts, and per-request generation lengths. Include the mechanical typing, formatting, and exception-preserving corrections required by pinned lint checks on the touched backend.
Fixes #4406.
Validation: