openai: better error messages; fix greedy matching #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baberabb
requested review from
haileyschoelkopf and
lintangsutawika
as code owners
haileyschoelkopf
requested changes
Sep 26, 2024
Co-authored-by: Hailey Schoelkopf <[email protected]>
Co-authored-by: Hailey Schoelkopf <[email protected]>
|
@haileyschoelkopf add your suggestions! thanks |
haileyschoelkopf
approved these changes
Sep 26, 2024
giuliolovisotto
pushed a commit
to giuliolovisotto/lm-evaluation-harness
that referenced
this pull request
Sep 27, 2024
* better error message; fix greedy matching * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * pre-commit --------- Co-authored-by: Hailey Schoelkopf <[email protected]>
shachardon
pushed a commit
to shachardon/lm-evaluation-harness
that referenced
this pull request
Oct 1, 2024
* better error message; fix greedy matching * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * pre-commit --------- Co-authored-by: Hailey Schoelkopf <[email protected]>
mariagrandury
pushed a commit
to somosnlp/lm-evaluation-harness
that referenced
this pull request
Oct 9, 2024
* better error message; fix greedy matching * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * Update lm_eval/models/openai_completions.py Co-authored-by: Hailey Schoelkopf <[email protected]> * pre-commit --------- Co-authored-by: Hailey Schoelkopf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2326, closes #2318, closes #2287