Resolve gradient accumulation memory leak #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found three main sources of memory increase:
Fix: Freed activations immediately after the backward pass, reducing memory usage for grad_accum=2 to match grad_accum=1.
Fix: Explicitly free IPG buffers when an overflow is detected.
Tested on a 1-3B GPT-NeoX model configuration.
Loss values and iteration time are identical to the main branch.