Fix BOLT11 annotation loss after restart #8571
Conversation
wqxoxo
force-pushed
the
feat/issue-6978-bolt11-annotation-fix
branch
2 times, most recently
from
2dd3a32 to
7ad18fa
Compare
|
This bug report, and fix, are a mystery to me! What is the user visible change over restart? What list command is missing what field? listhtlcs? listsendpays? listforwards? listpeerchannels? listpays? The test tests that entries are created in the database, but so what? Users don't see the database. This doesn't test whatever this is supposed to fix, so I can't even tell that... |
wqxoxo
force-pushed
the
feat/issue-6978-bolt11-annotation-fix
branch
2 times, most recently
from
8ba9e19 to
48ffa71
Compare
Fixes ElementsProject#6978 where BOLT11 invoice annotations were lost after lightning node restart due to broken linkage between HTLCs and payment records. Add payment_id column to channel_htlcs table with proper foreign key relationship to maintain HTLC-payment linkage through restarts.
|
You're right, the test was focused on the database. User visible change: listpays (and listsendpays) lose the bolt11 field after restart. Which commands: listpays and listsendpays are affected. The others (listhtlcs, listforwards, listpeerchannels) never showed bolt11 anyway. The root issue is HTLCs had no link back to payment records after restart so the bolt11 annotation got lost. Added a payment_id foreign key to fix it. Does that make more sense? @rustyrussell |
Summary
Fixes #6978 where BOLT11 invoice annotations were lost after lightning node restart.
Problem
HTLCs cannot be linked back to their originating payment records after restart. The
channel_htlcstable lacks a direct foreign key reference to payments, making BOLT11 annotations appear "lost".Solution
Add
payment_idcolumn tochannel_htlcstable with proper foreign key relationship to maintain HTLC-payment linkage through restarts.