Fix bkpr rebalance parsing on startup #8562
Open
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/fix-bkpr-rebalance-parse
branch
from
f1a771e to
a2bf1cf
Compare
```
lightningd-1 2025-09-22T02:10:10.978Z **BROKEN** plugin-bookkeeper: Unparsable datastore ["bookkeeper","rebalances","1-2"]
```
And, indeed, rebalance is missing:
```
> outbound_ev = only_one([ev for ev in inc_evs if ev['tag'] == 'rebalance_fee'])
tests/test_bookkeeper.py:825:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
arr = []
def only_one(arr):
"""Many JSON RPC calls return an array; often we only expect a single entry
"""
> assert len(arr) == 1
E AssertionError
```
Signed-off-by: Rusty Russell <[email protected]>
Parse key correctly. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: bookkeeper: failed reload of rebalances on restart.
rustyrussell
force-pushed
the
guilt/fix-bkpr-rebalance-parse
branch
from
a2bf1cf to
5263318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test rebalances, but we didn't restart and check persistence :(
Not sure if this fixes the crash though...
See: #8549