Skip to content

fix: add feature for payment_secret #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add feature for payment_secret #8330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48182ef
refactor: make test more flexible
king-11 Jun 10, 2025
c88ed6e
fix: skip access test when root
king-11 Jun 10, 2025
8472f8d
test: remove hardcoded message
king-11 Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_clnrest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def test_websocket_upgrade_header(node_factory):
@sio.event
def message(data):
notifications.append(data)
with pytest.raises(socketio.exceptions.ConnectionError, match="Unexpected response from server"):
with pytest.raises(socketio.exceptions.ConnectionError):
sio.connect(base_url)

time.sleep(2)
Expand Down
7 changes: 4 additions & 3 deletions tests/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,9 +1171,9 @@ def test_cli_multiline_help(node_factory):
'--lightning-dir={}'
.format(l1.daemon.lightning_dir),
'help', 'helpme']).decode('utf-8')
assert out == ("helpme msat \n"
" This is a message which consumes multiple lines and thus should\n"
" be well-formatted by lightning-cli help\n")
assert ("helpme msat \n"
" This is a message which consumes multiple lines and thus should\n"
" be well-formatted by lightning-cli help\n" in out)


def test_cli_commando(node_factory):
Expand Down Expand Up @@ -4382,6 +4382,7 @@ def test_setconfig(node_factory, bitcoind):
assert lines == ["# Created and update by setconfig, but you can edit this manually when node is stopped.", "min-capacity-sat=400000"]


@pytest.mark.skipif(os.getuid() == 0, reason="Test requires non-root user for permission checks to work")
def test_setconfig_access(node_factory, bitcoind):
"""Test that we correctly fail (not crash) if config file/dir not writable"""

Expand Down
Loading