fuzz-tests: Add fuzz target for closing_sig #8244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morehouse
reviewed
Apr 22, 2025
tests/fuzz/fuzz-wire-closing_sig.c
Outdated
Comment on lines
35
to
37
| assert(!memcmp(&x->channel_id, &y->channel_id, sizeof(struct channel_id))); | ||
| assert(x->locktime == y->locktime); | ||
| assert(!memcmp(&x->fee_satoshis, &y->fee_satoshis, sizeof(struct amount_sat))); |
There was a problem hiding this comment.
Suggested change
| assert(!memcmp(&x->channel_id, &y->channel_id, sizeof(struct channel_id))); | |
| assert(x->locktime == y->locktime); | |
| assert(!memcmp(&x->fee_satoshis, &y->fee_satoshis, sizeof(struct amount_sat))); | |
| assert(memcmp(&x->channel_id, &y->channel_id, sizeof(x->channel_id)) == 0); | |
| assert(x->locktime == y->locktime); | |
| assert(memcmp(&x->fee_satoshis, &y->fee_satoshis, sizeof(x->fee_satoshis)) == 0); |
There was a problem hiding this comment.
Ugh, my bad. This change should have been carried over from the review on #8216 .
There was a problem hiding this comment.
We have various _eq functions for clarity. In this case, channel_id_eq() and amount_sat_eq().
| assert(tal_arr_eq(x->closee_scriptpubkey, y->closee_scriptpubkey)); | ||
|
|
||
| assert(x->tlvs && y->tlvs); | ||
| return tal_arr_eq(x->tlvs->closer_and_closee_outputs, y->tlvs->closer_and_closee_outputs); |
There was a problem hiding this comment.
Also need to compare these TLVs:
closer_output_only
closee_output_only
added 2 commits
April 23, 2025 15:00
Changelog-None: 'closing_signed' and 'closing_sig' are channel closing negotiation messages defined in BOLT ElementsProject#2. While 'closing_signed' has a wire fuzz test, 'closing_sig' does not. Add a test to perform a round-trip encoding check (towire -> fromwire) similar to the other wire fuzzers.
Add a minimal input set as a seed corpus for the newly introduced test. This leads to discovery of interesting code paths faster.
morehouse
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing_signedandclosing_sigare channel closing negotiation messages defined in BOLT #2.While
closing_signedhas a wire fuzz test,closing_sigdoes not. Add a test to perform a round-trip encoding check (towire -> fromwire) similar to the other wire fuzzers.With this PR and #8216 , wire fuzzing is covered for all types of wire messages (except subtypes).
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse