cln-grpc Expose NotificationStream
#8220
Conversation
nepet
force-pushed
the
cln-grpc-make-notificiation-stream-public
branch
from
8202b0b to
423df26
Compare
The `cfg-if` macro allows us to organise feature flag related exports in a more concise way. Signed-off-by: Peter Neuroth <[email protected]>
Services that want to wrap the server implementation will need access to the `NotificationStream` struct in order to pass the stream through. Changelog-Added: `cln-grpc` Exposed NotificationStream in the server module Signed-off-by: Peter Neuroth <[email protected]>
nepet
force-pushed
the
cln-grpc-make-notificiation-stream-public
branch
from
423df26 to
3a35c2c
Compare
| #[cfg(feature = "server")] | ||
| pub use crate::server::Server; | ||
| cfg_if::cfg_if! { | ||
| if #[cfg(feature = "server")] { |
There was a problem hiding this comment.
Sorry wat? Just make it available as a public re-export, independently of features. Having too many features around complicates the test matrix considerably. Or make it a client feature, negating a feature is super weird
There was a problem hiding this comment.
There seems to be a missunderstanding. I am not negating some feature, cfg_if! is a macro that just cleans up three rows of #[cfg(feature = "server")] into one bracket.
https://docs.rs/cfg-if/latest/cfg_if/
But of course I can revert that if we don't like that.
Also, I did not see much advantage in exporting NotificationStream to clients as it implements the tokio_stream::Stream trait which makes it accessible further down the line.
There was a problem hiding this comment.
Ah, now I see. Wouldn't this be equivalent to
#[cfg(feature="server")]
{
mod a;
mod b;
mod c;
}
Or does the lexical scoping result in a b and c not being accessible at the module then?
There was a problem hiding this comment.
It would be nice if this worked, but unfortunately the compiler does not accept it. Rust seems to force you into declaring the feature check for every line (in lib.rs).
There was a problem hiding this comment.
The trick to do this is to have a big submodule file, and you will have something like
#[cfg(feature="server")]
mod server;
where server.rs
mod a;
mod b;
mod c;
IIRC, this should avoid also collision and IMHO is an elegant solution
This PR exposes the
NotificationStreamof the grpc server implementation. This is required for wrapping services to be able to pass down any notification stream.