Skip to content

cln-plugin: don't panic if notification handler returns error #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cln-plugin: don't panic if notification handler returns error #8189

wants to merge 1 commit into from

Conversation

daywalker90
Copy link
Contributor

Changelog-None

Important

25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@daywalker90 daywalker90 requested a review from cdecker as a code owner March 31, 2025 09:47
vincenzopalazzo
vincenzopalazzo suggested changes Apr 3, 2025
View reviewed changes
@daywalker90
Copy link
Contributor Author

daywalker90 commented Apr 3, 2025 •
edited
Loading

Just wrote for a project which required always match instead of if let^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo requested changes

@cdecker cdecker Awaiting requested review from cdecker cdecker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daywalker90 @vincenzopalazzo