fuzz-tests: Add differential test for HMAC-SHA256 #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
reviewed
Mar 30, 2025
Makefile
Outdated
| @@ -283,7 +283,7 @@ ifeq ($(STATIC),1) | |||
| # But that doesn't static link. | |||
| LDLIBS = -L$(CPATH) -Wl,-dn $(SQLITE3_LDLIBS) -Wl,-dy -lm -lpthread -ldl $(COVFLAGS) | |||
| else | |||
| LDLIBS = -L$(CPATH) -lm $(SQLITE3_LDLIBS) $(COVFLAGS) | |||
There was a problem hiding this comment.
Question for the linker experts: does this end up linking CLN against openssl in release builds? If yes, we should reduce the linker arg changes to just impact the fuzz testing.
There was a problem hiding this comment.
Question for the linker experts: does this end up linking CLN against openssl in release builds? If yes, we should reduce the linker arg changes to just impact the fuzz testing.
You're right, that's an error on my part. I should've instead added this line in tests/fuzz/Makefile:
tests/fuzz/fuzz-hmac-sha256: LDLIBS += -lcrypto
which is similar to the linking routine for SHA256 and RIPEMD160 fuzz tests. I'll add this change in the next push.
|
CC: @morehouse |
added 2 commits
April 16, 2025 12:00
Changelog-None: Add a differential fuzz test for HMAC-SHA256, similar to those for SHA256 and RIPEMD160, to verify CCAN’s implementation against OpenSSL’s.
Add a minimal input set as a seed corpus for the newly introduced test. This leads to discovery of interesting code paths faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a differential fuzz test for
HMAC-SHA256, similar to thosefor
SHA256andRIPEMD160, to verify CCAN’s implementationagainst OpenSSL’s.