xpay: add marfeepercent argument #7936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Added: xpay: maxfeepercent argument to match some API uses like legacy pay Signed-off-by: Lagrang3 <[email protected]>
Adding a "status" field to the rpc response avoids breaking changes to applications that use the legacy pay API if they try to use xpay through the `xpay-handle-pay` hook. Changelog-Added: xpay: add status field to rpc response Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
xpay-fix-maxfeepercent
branch
from
7910b80 to
de6c292
Compare
Changelog-None Signed-off-by: Lagrang3 <[email protected]>
michael1011
reviewed
Dec 14, 2024
| maxfee_set = true; | ||
| } | ||
|
|
||
| /* Default is maxfee is 5sats, or 1%, whatever is greater */ |
There was a problem hiding this comment.
Why not have the same behaviour as pay with 0.5%? Imho it's a reasonable value that will get the payment through
There was a problem hiding this comment.
Yes, we should do exactly the same logic, to avoid surprises!
|
No, I don't want this in xpay, let's do this in the compat layer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maxfeepercent argument to xpay to match some API uses like legacy pay.
Addresses (solves?) issue #7926.
As a user of Zeus wallet connected to my core-lightning node I can't use xpay using the provided default
hook (
xpay-handle-pay) because the app sends through RPC some arguments that xpay does not yet handleand falls back to legacy pay. For example
maxfeepercent.I would like to add support for as many arguments as possible or add some workarounds in order to make
xpay work on these use cases.