Skip to content

add typescript table row generics #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add typescript table row generics #1077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ declare namespace ElementReact {
export class Slider extends ElementReactLibs.Component<SliderProps, {}> { }

// Table
interface TableColumn {
interface TableColumn<RowType> {
label?: string
prop?: string
property?: string
Expand All @@ -619,11 +619,11 @@ declare namespace ElementReact {
fixed?: boolean | string
filterMethod?: () => void
filters?: Object[]
render?: (data? :Object, column? :Object, index? :number) => void
render?: (data? :RowType, column? :Object, index? :number) => void
}
interface TableProps extends ElementReactLibs.ComponentProps<{}> {
columns?: TableColumn[]
data?: Object[]
interface TableProps<RowType> extends ElementReactLibs.ComponentProps<{}> {
columns?: TableColumn<RowType>[]
data?: RowType[]
height?: number
stripe?: boolean
border?: boolean
Expand All @@ -635,7 +635,7 @@ declare namespace ElementReact {
onSelectAll?(): void
onSelectChange?(): void
}
export class Table extends ElementReactLibs.Component<TableProps, {}> { }
export class Table<RowType extends Object = Object> extends ElementReactLibs.Component<TableProps<RowType>, {}> { }

// Switch
interface SwitchProps extends ElementReactLibs.ComponentProps<{}> {
Expand Down