Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer dispatch parameters from commad signatures (Sourcery refactored) #139

Merged

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Aug 26, 2021

Pull Request #138 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the dispatch-inspect-parameters branch, then run:

git fetch origin sourcery/dispatch-inspect-parameters
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from jlaasonen August 26, 2021 07:34
@sourcery-ai sourcery-ai bot force-pushed the sourcery/dispatch-inspect-parameters branch from 1f79cfa to 5609537 Compare August 26, 2021 07:34
@sourcery-ai sourcery-ai bot force-pushed the sourcery/dispatch-inspect-parameters branch from 5609537 to 22b0815 Compare August 26, 2021 07:35
Comment on lines -43 to +50
if pages:
try:
int(pages)
return id, pages
except ValueError:
raise DataError(f'Pages "{pages}" not numeric.')
else:
if not pages:
return id, ""

try:
int(pages)
return id, pages
except ValueError:
raise DataError(f'Pages "{pages}" not numeric.')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function FragmentSearch._validate_pages refactored with the following changes:

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Aug 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.09%.

Quality metrics Before After Change
Complexity 2.20 ⭐ 1.27 ⭐ -0.93 👍
Method Length 42.00 ⭐ 42.25 ⭐ 0.25 👎
Working memory 6.20 🙂 5.73 ⭐ -0.47 👍
Quality 85.10% 87.19% 2.09% 👍
Other metrics Before After Change
Lines 52 52 0
Changed files Quality Before Quality After Quality Change
ebl/fragmentarium/web/fragment_search.py 85.10% ⭐ 87.19% ⭐ 2.09% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ebl/fragmentarium/web/fragment_search.py FragmentSearch.__init__ 0 ⭐ 67 🙂 14 😞 67.20% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@jlaasonen jlaasonen merged commit 6fbf081 into dispatch-inspect-parameters Aug 26, 2021
@jlaasonen jlaasonen deleted the sourcery/dispatch-inspect-parameters branch August 26, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant