Skip to content

BrowserWindowOptions; Fix default and add more Tests #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
+5 −4
Merged

BrowserWindowOptions; Fix default and add more Tests #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1815951
BrowserWindowOptions; Fix default for FullScreenable
softworkz Nov 20, 2025
2f4d37d
Try macOS 26
softworkz Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
rid: linux-x64
- os: windows-2022
rid: win-x64
- os: macos-14
- os: macos-26
rid: osx-arm64

env:
Expand Down
7 changes: 4 additions & 3 deletions src/ElectronNET.API/API/Entities/BrowserWindowOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,11 @@ public class BrowserWindowOptions

/// <summary>
/// Whether the window can be put into fullscreen mode. On macOS, also whether the
/// maximize/zoom button should toggle full screen mode or maximize window.Default
/// is true.
/// maximize/zoom button should toggle full screen mode or maximize window. Default
/// is true (Electron default).
/// </summary>
public bool Fullscreenable { get; set; }
[DefaultValue(true)]
public bool Fullscreenable { get; set; } = true; // FIX: previously defaulted to false in C#

/// <summary>
/// Whether to show the window in taskbar. Default is false.
Expand Down