Skip to content

Conversation

@softworkz
Copy link
Contributor

Create a baseline with common formatting, so that PRs can be made without including whitespace changes

Copilot AI review requested due to automatic review settings November 9, 2025 02:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs comprehensive code formatting and style standardization across the ElectronNET codebase. The changes focus on improving code consistency and readability through whitespace normalization, indentation fixes, and standardized formatting patterns.

  • Standardizes whitespace and blank line usage throughout the codebase
  • Reformats constructors, properties, and lambda expressions to use consistent multi-line styles
  • Fixes indentation inconsistencies
  • Improves encapsulation by making the oneCallguid field private in HostHook.cs

Reviewed Changes

Copilot reviewed 42 out of 50 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AspNetLifetimeAdapter.cs Removed extra whitespace in class declaration and EOF
StartupManager.cs Fixed indentation of Console.WriteLine and removed trailing blank line
SocketBridgeService.cs Removed extra whitespace in class declaration and EOF
LifetimeServiceBase.cs Expanded empty constructor to multi-line format
RuntimeControllerElectronFirst.cs Removed trailing blank lines
RuntimeControllerDotNetFirst.cs Removed trailing blank lines
RuntimeControllerBase.cs Removed blank lines within methods
ApiEventManager.cs Standardized blank line placement between methods
SocketIOFacade.cs Condensed multi-line lambdas to single-line and fixed indentation
Events.cs Expanded constructor format and removed trailing blank line
WindowManager.cs Expanded constructor and added spacing after properties
WebRequest.cs Fixed lambda indentation and added property spacing
WebContents.cs Added spacing after if keywords
Tray.cs Expanded constructor and added consistent method spacing
Shell.cs Condensed lambdas and added spacing around cast operators
Session.cs Added EOF newline
Screen.cs Expanded constructor and removed trailing whitespace
Process.cs Expanded constructor and cleaned up excessive blank lines
PowerMonitor.cs Expanded constructor and standardized whitespace
Notification.cs Expanded constructor and reformatted lambda expressions
NativeTheme.cs Expanded constructor and reformatted lambda expressions
Menu.cs Expanded constructor/property getters and reformatted lambdas
IpcMain.cs Expanded constructor, added spacing after if, reformatted lambdas
HostHook.cs Made oneCallguid field private and expanded constructor
GlobalShortcut.cs Expanded constructor format
MenuItemExtensions.cs Added spacing after if keyword
EnumExtensions.cs Added blank line before return statement
Entity files (multiple) Various whitespace and spacing standardization
Electron.cs Expanded all property getters to multi-line format
Dock.cs Added spacing around casts, expanded property getters, reformatted lambdas
Dialog.cs Expanded constructor, improved indentation, added if spacing
Cookies.cs Added blank line after property setter
CommandLine.cs Expanded constructor and removed trailing whitespace
Clipboard.cs Expanded constructor and cleaned up whitespace
BrowserWindow.cs Expanded property getters and added consistent spacing
BrowserView.cs Added spacing and EOF newline
AutoUpdater.cs Expanded constructor and removed excessive blank lines
App.cs Extensive formatting improvements to properties, methods, and whitespace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FlorianRappl FlorianRappl merged commit 84989cd into ElectronNET:develop Nov 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants