Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeylScal4: disable OMP #33

Merged
merged 2 commits into from
Jul 18, 2024
Merged

WeylScal4: disable OMP #33

merged 2 commits into from
Jul 18, 2024

Conversation

lwJi
Copy link
Collaborator

@lwJi lwJi commented Jul 18, 2024

No description provided.

@lwJi lwJi requested a review from rhaas80 July 18, 2024 02:28
@rhaas80
Copy link
Member

rhaas80 commented Jul 18, 2024

While you are doing this I'd also add the correct support for tiling using the cctk_tile_min / cctk_tile_max variables.

@rhaas80
Copy link
Member

rhaas80 commented Jul 18, 2024

commit message might be somewhat confusing for people. possible say "disable omp for" since OpenMP itself is still active (via CarpetX's use of it).

rhaas80
rhaas80 requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@rhaas80 rhaas80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, when doing this change I'd also add the correct cctk_tile_min and cctk_tile_max limits (so that the data is not computed multiple times).

@lwJi lwJi force-pushed the lwji/WeylScal4 branch from 3036cad to d2a7654 Compare July 18, 2024 20:05
@lwJi
Copy link
Collaborator Author

lwJi commented Jul 18, 2024

see comments, when doing this change I'd also add the correct cctk_tile_min and cctk_tile_max limits (so that the data is not computed multiple times).

Done

@lwJi lwJi merged commit f6b2a57 into main Jul 18, 2024
12 checks passed
@lwJi lwJi deleted the lwji/WeylScal4 branch July 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaas80 rhaas80 rhaas80 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwJi @rhaas80