Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z4c: fix bug related to the misuse of sym_symm #32

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Z4c: fix bug related to the misuse of sym_symm #32

merged 2 commits into from
Jul 17, 2024

Conversation

lwJi
Copy link
Collaborator

@lwJi lwJi commented Jul 11, 2024

Be careful when using sym_symm, make sure both of the two tensors are symmetric.
we can't use it for $\partial_c\gamma^{a(e}\gamma^{f)b}A_{ab}$, because $\partial_c\gamma^{a(e}\gamma^{f)b}$ is not symmetric in $(ab)$

@lwJi lwJi requested a review from eschnett July 11, 2024 15:38
Copy link
Contributor

@eschnett eschnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that the expressions themselves are correct, i.e. whether the implemented equations correspond to the ones in the paper? I might e.g. have changed the order of indices.

@lwJi
Copy link
Collaborator Author

lwJi commented Jul 17, 2024

Did you check that the expressions themselves are correct, i.e. whether the implemented equations correspond to the ones in the paper? I might e.g. have changed the order of indices.

I checked all the terms and compared them with the paper. I believe they now all agree. @eschnett

@lwJi lwJi merged commit 0e09497 into main Jul 17, 2024
12 checks passed
@lwJi lwJi deleted the lwji/Z4c branch July 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants