Added Local /.AWS/Credential check, coloring terminal output, checking for aws cli#10
Added Local /.AWS/Credential check, coloring terminal output, checking for aws cli#10InfiniteInsight wants to merge 16 commits into
Conversation
…version to 1.01, added def check_for_local_aws_credential
… IAM Role can be assumed
… added a call to utils.create_downloads_folder, added 'aws' to the prerequisite check alongside trufflehog3
…rray to contain a list of public buckets to prepare for async operations
…version to 1.01, added def check_for_local_aws_credentials
|
Here is the original comment from the pull request that I closed earlier today: I saw that you had created a Colors class so I used it to style the terminal output and logs to make errors, informational and successful messages stand out better. I added detailed error messages with suggested solutions to points of failure. I added a function to check for local AWS credentials for people who might not be well versed with AWS but may need to scan buckets. I made some minor changes to the readme to make it clear that the CSV file is currently required in order for S3cret Scanner to run. Other minor points of clarification. Hope this is helpful! I am still hopeful to make this run async instead of synchronously, as the STS token is apt to expire for very large buckets even if you extend the time to the maximum. |
noticed extra \
|
gentle bump :) |
|
Thanks @InfiniteInsigh, reviewing in STG and comment / merge PR soon 🤘 |
|
@Eilonh checking in! |
I realized that using blob to check for the .aws folder was not expanding ~ to mean the user's home folder.
I decided to change the way the text is colored in most instances, condensing where appropriate unless I wanted a blank line.
I also started staging the async operations, figuring I will aggregate the public buckets into an array to then iterate through asynchronously to avoid the token expiring too soon.