Skip to content

Added Local /.AWS/Credential check, coloring terminal output, checking for aws cli#10

Open
InfiniteInsight wants to merge 16 commits into
Eilonh:mainfrom
InfiniteInsight:dev
Open

Added Local /.AWS/Credential check, coloring terminal output, checking for aws cli#10
InfiniteInsight wants to merge 16 commits into
Eilonh:mainfrom
InfiniteInsight:dev

Conversation

@InfiniteInsight
Copy link
Copy Markdown

I realized that using blob to check for the .aws folder was not expanding ~ to mean the user's home folder.

I decided to change the way the text is colored in most instances, condensing where appropriate unless I wanted a blank line.

I also started staging the async operations, figuring I will aggregate the public buckets into an array to then iterate through asynchronously to avoid the token expiring too soon.

@InfiniteInsight
Copy link
Copy Markdown
Author

Here is the original comment from the pull request that I closed earlier today:

I saw that you had created a Colors class so I used it to style the terminal output and logs to make errors, informational and successful messages stand out better.

I added detailed error messages with suggested solutions to points of failure.

I added a function to check for local AWS credentials for people who might not be well versed with AWS but may need to scan buckets.

I made some minor changes to the readme to make it clear that the CSV file is currently required in order for S3cret Scanner to run.

Other minor points of clarification.

Hope this is helpful!

I am still hopeful to make this run async instead of synchronously, as the STS token is apt to expire for very large buckets even if you extend the time to the maximum.

@InfiniteInsight InfiniteInsight changed the title Dev Added Local /.AWS/Credential check, coloring terminal output, checking for aws cli Nov 20, 2022
@InfiniteInsight
Copy link
Copy Markdown
Author

gentle bump :)

@Eilonh
Copy link
Copy Markdown
Owner

Eilonh commented Dec 3, 2022

Thanks @InfiniteInsigh, reviewing in STG and comment / merge PR soon 🤘

@InfiniteInsight
Copy link
Copy Markdown
Author

@Eilonh checking in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants