🎨 Palette: Improve keyboard accessibility and add ARIA attributes to mario game#126
🎨 Palette: Improve keyboard accessibility and add ARIA attributes to mario game#126
Conversation
…ario game Adds a visible keyboard control hint for players to jump and `aria-live` and `aria-atomic` attributes to the `#score` element for proper screen reader announcements. Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removing the built-in python module `venv` from `requirements.txt` fixes the CI pipeline failing on `pip install` with 'No matching distribution found for venv'. Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
1 participant
💡 What:
Added a visible keyboard shortcut hint ("Press Space or Up Arrow to jump") to the Mario game and improved accessibility by adding ARIA attributes to the score element.
🎯 Why:
The game lacked visual instructions for how to play, making it unintuitive for new users. Additionally, the score was dynamically updating without announcing those changes to screen readers.
📸 Before/After:
Before: The score updated silently in the DOM, and there were no visual instructions.
After: The score now has
aria-live="polite"andaria-atomic="true"to announce updates, and a clean text hint tells users how to jump.♿ Accessibility:
aria-live="polite"to#scoreso screen readers will announce score updates gracefully.aria-atomic="true"to#scoreto ensure the entire score element is read, not just the changed number.aria-hidden="true", ensuring screen reader users also know the controls.PR created automatically by Jules for task 14226623491108992998 started by @EiJackGH