Support Project Contributors and Enhance Simulation Robustness#121
Support Project Contributors and Enhance Simulation Robustness#121aidasofialily-cmd wants to merge 1 commit intomainfrom
Conversation
- Fix `requirements.txt`: remove `venv`, add `pytest`. - Acknowledge contributors in `CONTRIBUTORS.md` and `README.md`. - Add `--contributors` flag and support message to `bitcoin_trading_simulation.py`. - Fix trading logic to handle initial signals and improve state management. - Update and expand test suite (13/13 passing). Co-authored-by: aidasofialily-cmd <247843425+aidasofialily-cmd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
aidasofialily-cmd
temporarily deployed
to
production
GitHub Actions
Inactive
1 participant
This PR acknowledges the project's contributors and improves the simulation's reliability.
Key changes:
venv(a standard library module) fromrequirements.txtand addedpytestto support the existing test suite.CONTRIBUTORS.mdfile and updated theREADME.mdto properly creditEiJackGH,aidasofialily-cmd, and the AI development assistant.--contributorsflag to the simulation tool to display the team names and included a call-to-action in the final performance report to encourage users to star the repository.bitcoin_trading_simulation.py. The simulation now uses a state-based trigger (current signal + current holdings) instead of a transition-based trigger (positionsdiff). This ensures that buy/sell signals occurring at the very beginning of the simulation are no longer missed.test_bitcoin_trading.pyto include the required columns and added new test cases totest_simulation.pyto verify that initial market entries are correctly handled. All 13 tests are passing.PR created automatically by Jules for task 12755216825196516939 started by @aidasofialily-cmd