Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable descriptions #21

Merged
merged 5 commits into from
Feb 6, 2019
Merged

Conversation

4xdk
Copy link
Collaborator

@4xdk 4xdk commented Jan 12, 2019

No description provided.

@4xdk
Copy link
Collaborator Author

4xdk commented Jan 12, 2019

@elimisteve
Copy link
Member

Hey @4xdk, A+ on all the API call-y code and all the Redux-y code. I'm sorry my initial instructions were so vague, but can we work on this together to make it non-WYSIWYG?

Overall, if it behaves pretty much exactly like GitHub's comment boxes, where we can type Markdown and it renders as, well, rendered Markdown, that would be perfect -- exactly like we did with LeapChat: https://leapchat.noisebridge.info/#ComputerCensusOzoneAidlessEvolutionGlassesRequestRulebookJukeboxTallnessSaddlebagAmendmentWaterNanosecondGongLazybonesDimpleSixfoldHubcapTumbleweedLuridnessOnstageUntiedDatebookObserver

And in fact, here is that functionality: https://github.com/cryptag/leapchat/blob/32bfca06ddc20c35b437d086f7b04c475256236b/src/components/chat/Message.js#L11-L57 .

Hey @Moe-Shoman , want to help add ^^your^^ auto-complete goodness to task descriptions, even before #22 if you'd like? Up to you.

@4xdk
Copy link
Collaborator Author

4xdk commented Jan 26, 2019

Could you check if this is what you meant @elimisteve please? I basically disabled the editor from applying styles to the typed text during typing. Was a bit annoying tbh anyway ;)

Also I'm thinking it'd be good to update the package version prior to going live as it's being quite actively worked on and has some bugs here and there. https://github.com/facebook/draft-js

@elimisteve
Copy link
Member

@4xdk Ah that sounds like a smart play. I need to sleep soon -- I have a really early meeting (namely at noon lol) -- but tomorrow I will look at this more.

See also the issues where I mentioned you and @Moe-Shoman; some other really valuable stuff that I'd love some help with!

@elimisteve elimisteve merged commit 5960bd0 into EffectiveAF:master Feb 6, 2019
@4xdk 4xdk deleted the editable-descriptions branch February 9, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants