Skip to content

Fix/catchtag errors #5075 #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jfet97
Copy link

@jfet97 jfet97 commented Jun 24, 2025

Description

This is just a draft, it helps me to highlight the problem I found. That ...args trick is clever when it comes to step over the "A rest parameter must be last in a parameter list." error, but it seems to not play well with the kind of contextual parameters inference Effect.fnUntraced needs. OTOH the solution outlined in my commit requires manually passing an array of tags so the DX it's a little bit worse (and this should be ported to every overload of catchTag).

Related

Related Issue #5075

@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Jun 24, 2025
Copy link

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: 168ae44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tim-smart
Copy link
Contributor

The issue is actually with the overload that assists autocompletion, if you remove it the ...args inference will work.

@jfet97
Copy link
Author

jfet97 commented Jun 25, 2025

The issue is actually with the overload that assists autocompletion, if you remove it the ...args inference will work.

I wasn't considering the possibility to remove those overloads you added at all ahah

@jfet97 jfet97 closed this Jun 25, 2025
@github-project-automation github-project-automation bot moved this from Discussion Ongoing to Done in PR Backlog Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants