feat(registry): support configured db schema#102
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 239596c8e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assertValidRegistrySchemaName(schemaName) | ||
|
|
||
| const url = new URL(connectionString) | ||
| url.searchParams.set('options', `-c search_path=${schemaName},public`) |
There was a problem hiding this comment.
Quote mixed-case schema names in search_path
When REGISTRY_DB_SCHEMA contains uppercase letters (which the validator accepts), this unquoted search_path entry is folded to lowercase by Postgres, while ensureConfiguredRegistrySchema creates the schema as a quoted case-sensitive name. For example REGISTRY_DB_SCHEMA=Registry creates schema "Registry", but the client searches registry,public, so migrations and runtime tables fall back to public instead of the configured schema. Either reject uppercase names or quote/escape the search path entry consistently with schema creation.
Useful? React with 👍 / 👎.
Summary
Verification