feat(discovery): support configured db schema#101
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a69b90aa0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DATABASE_URL: postgresql://${POSTGRES_USER:-fides}:${POSTGRES_PASSWORD:?Set POSTGRES_PASSWORD in .env}@postgres:5432/${POSTGRES_DB:-fides} | ||
| DISCOVERY_PORT: "3100" | ||
| DISCOVERY_DB_AUTO_MIGRATE: ${DISCOVERY_DB_AUTO_MIGRATE:-true} | ||
| DISCOVERY_DB_SCHEMA: ${DISCOVERY_DB_SCHEMA:-discovery} |
There was a problem hiding this comment.
For existing Docker Compose deployments with a persisted Postgres volume and no DISCOVERY_DB_SCHEMA in .env, this new default silently moves discovery from the previously used public schema to a fresh discovery schema. On upgrade, runDiscoveryMigrations will create empty tables there, so registered identities/agents appear to be lost until operators discover and override the variable or manually migrate data. Make the schema opt-in for Compose upgrades or provide an explicit migration/compatibility path.
Useful? React with 👍 / 👎.
| assertValidSchemaName(schemaName) | ||
|
|
||
| const url = new URL(connectionString) | ||
| url.searchParams.set('options', `-c search_path=${schemaName},public`) |
There was a problem hiding this comment.
When DISCOVERY_DB_SCHEMA contains uppercase letters, which assertValidSchemaName currently allows, this sends an unquoted search_path=Foo,public; PostgreSQL folds that to lowercase, while ensureConfiguredSchema creates the quoted schema "Foo". In that configuration the new schema is created but ignored, and migrations/queries fall back to public or a lowercase schema. Restrict the value to lowercase identifiers or quote/escape it consistently in the search path.
Useful? React with 👍 / 👎.
2 participants
Summary
Verification
Note: local discovery storage tests skipped because DATABASE_URL is not set locally; CI provides Postgres and will run them.