Issue #3017760: Support drush 9 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuee
reviewed
Dec 4, 2018
malcomio
commented
Dec 9, 2018
manuee
suggested changes
Dec 10, 2018
| * | ||
| * See these files for an example of injecting Drupal services: | ||
| * - http://cgit.drupalcode.org/devel/tree/src/Commands/DevelCommands.php | ||
| * - http://cgit.drupalcode.org/devel/tree/drush.services.yml |
There was a problem hiding this comment.
This docblock needs updating to describe the class itself.
| * Generates a database.sanitize.yml file. | ||
| * | ||
| * Generate database.sanitize.yml file for tables not specified on sanitize | ||
| * YML files. |
There was a problem hiding this comment.
This isn't correct, we do not generate a database.sanitize.yml file here, we just generate the content for it.
manuee
suggested changes
Dec 10, 2018
| services: | ||
| database_sanitize.commands: | ||
| class: \Drupal\database_sanitize\Commands\DatabaseSanitizeCommands | ||
| tags: |
There was a problem hiding this comment.
Lets inject here the database_sanitize service:
arguments: ['@database_sanitize']
Then add a constructor like on http://cgit.drupalcode.org/devel/tree/src/Commands/DevelCommands.php
There was a problem hiding this comment.
good idea - I probably won't get time to work on this over the next few days, so if you have time please could you take this forward?
|
Lets continue the work on the new branch 3017760 |
vijaycs85
added a commit
to vijaycs85/database_sanitize
that referenced
this pull request
Dec 13, 2018
suzymasri
pushed a commit
that referenced
this pull request
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress...