Skip to content

[EDN-3550] Add pipe option to dbsa #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from
Open

[EDN-3550] Add pipe option to dbsa #21

wants to merge 2 commits into from

Conversation

manuee
Copy link
Contributor

@manuee manuee commented Jun 11, 2019

Issue links

Description

  • Adds pipe option
  • Adds outputformat default to yaml for listing the tables
  • returns [result => TRUE/FALSE] depending on whether all tables are specified or not

@badjava
Copy link

badjava commented Jun 11, 2019

I tested it and the issue I see is that the returned results are mixed with both messages and json. Some examples. I think it should return one or the other. Also, --list doesn't return the result of the command although I guess that could be assumed if there are table results whereas the result is included in the message when not in machine readable format.

$ drush dbsa
There are 1 tables not defined on sanitize YML files                 [warning]
result: false

$ drush dbsa --list
There are 1 tables not defined on sanitize YML files                 [warning]
- user__field_blammo

$ drush dbsa --format=json
There are 1 tables not defined on sanitize YML files                 [warning]
{
    "result": false
}
$ drush dbsa --list --format=json
There are 1 tables not defined on sanitize YML files                 [warning]
[
    "user__field_blammo"
]
$ drush dbsa --list --pipe
There are 1 tables not defined on sanitize YML files                 [warning]
[
    "user__field_blammo"
]

@manuee manuee requested a review from badjava June 13, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants