Added Android SDK conflict issues #811
Conversation
Because this plugin rules, but compatibility issues suck!
|
Did you close this PR by accident? |
|
No, I modified the readme on my fork.
tomcatmwi/nativescript-plugin-firebase@c9d08ab
…On Sun, Jul 22, 2018 at 4:26 PM Eddy Verbruggen ***@***.***> wrote:
Did you close this PR by accident?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#811 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYbxtbkFJNiBlpbzZpryj50skZFKW1EQks5uJN_egaJpZM4VaCja>
.
|
|
I understand, and I'd like to consider adding that change to this repo but for that to work, this PR (made from your fork) needs to be reopened 😃 |
|
Reopened. |
|
Thanks! By the way, before changing the file in the platforms/android folder, did you try applying those changes to this file as well? |
|
No, I didn't play with the demo. But before writing that readme segment I made a blank new HelloWorld app, added the plugin and registered it on Firebase. The steps I described have all been tested. |
|
I understand, but I'm referring to changing the gradle file in the project source folder as opposed to the one in the build folder. That way you don't have to reapply those changes every time you remove the platforms/android folder. So if your suggested changes work just as well when changing the file I referred to, I'd rather suggest users to apply the changes there ;) |
|
I see. Yes, I tried, but NativeScript doesn't seem to give a damn. I guess the build.gradle file is generated only if it doesn't exist. |
Because this plugin rules, but compatibility issues suck!