This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Suggestion: Return error objects instead of error message string #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,7 @@ export function uploadFile(arg: UploadFileOptions): Promise<UploadFileResult> { | |||
|
|
|||
| const onFailureListener = new gmsTasks.OnFailureListener({ | |||
| onFailure: exception => { | |||
| reject("Upload failed. " + exception); | |||
| reject(exception); | |||
There was a problem hiding this comment.
I'm not sure it's wise to return the native Java Exception object here. It used to be a String representation. Not saying that's perfect, but this is not better imo.
There was a problem hiding this comment.
I'm not sure either, that's why it's a rough fix. But if not the entire object, the Google error code may still work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a quick and somewhat quick and dirty implementation for Storage only. If you only return the error message string from Firebase, it's difficult to process in the app. I suggest to return the
exceptionorerrorobject instead:That will carry the error code and it can be extracted with
.errorCode()if needed, and existing code which expects a string also won't break. Seems to work on Android but I didn't test it on iOS.