Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jsdoc): correct submenu function args order #224

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Congiary
Copy link
Contributor

@Congiary Congiary commented Jun 5, 2024

After updating to version 9, the text of the buttons moved to options, while the documentation for submenu retained the previous implementation

Copy link
Owner

@EdJoPaTo EdJoPaTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Just a minor nitpick, then I'll merge it.

source/menu-template.ts Outdated Show resolved Hide resolved
@EdJoPaTo EdJoPaTo merged commit 45dfd2b into EdJoPaTo:main Jun 5, 2024
1 check passed
@EdJoPaTo
Copy link
Owner

EdJoPaTo commented Jun 5, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants