reactor_tests: add tests for transaction payment refund handling #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4636: Return None in case of an error in get_addressable_entity r=jacek-casper a=jacek-casper The current behaviour causes a problem in NCTL upgrade scenario 11, where we use `get_total_supply_key` from the state upgrade script. The `get_addressable_entity` function fails instead of returning None, while `get_total_supply_key` expects it to return None in order to handle the legacy format. The error type here has already been converted to a String, so we can't match precisely on the NotFound error. Co-authored-by: Jacek Malec <[email protected]>
…on/feat-2.0-integration-pr 2.0 Integration
Signed-off-by: Alexandru Sardan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.