[ADMINAPI-1477] - Moves Instance Management endpoints to /dataStores/manage (v3) and /odsInstances/manage (v2) - #408
Merged
Merged
Conversation
…anage Documents the plan to rename the shared DbInstance entity/table to OdsInstanceManage, move v2's DbInstances feature into OdsInstances/Manage (/v2/odsInstances/manage) and v3's DbDataStores feature into DataStores/Manage (/v3/dataStores/manage), and update all affected tests and E2E artifacts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nstanceManage Covers the in-place migration, shared entity/enum/config-key rename, v2's Features/DbInstances move to OdsInstances/Manage, v3's Features/DbDataStores move to DataStores/Manage, and all dependent unit/integration/E2E test updates. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nages This adds the 00007 migration script across both AdminApi and AdminApi.V3 artifacts for both MSSQL and PostgreSQL engines. The scripts use idempotency guards to safely rename the table, primary key constraint, and indexes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Renames the shared entity (DbInstance -> OdsInstanceManage), its status enum, JobConstants members, and AppSettings sweep/retry keys in the Common project, plus the matching DbSet/table mappings in both AdminApiDbContext classes and the four config keys in the v2/v3 appsettings files. Note: this intentionally leaves the solution non-building until Task 3 onward completes, since v2/v3 Features/Infrastructure/Jobs callers still reference the old names.
…l research) Task 3's implementer found that Features/Tenants/* and Infrastructure/Services/Tenants/TenantService.cs (both v2 and v3) also consume the renamed DbInstance/DbDataStore query and entity types, but the original plan never listed them. Folds the fix into the existing Tasks 5, 7, 12, and 14 rather than adding new task numbers. Also fixes the plan's incorrect .sln filename references (Ed-Fi-ODS-AdminApi.sln is the actual solution file).
…o /odsInstances/manage Task 4 of the OdsInstanceManage rename plan: relocates the v2 Features folder from Features/DbInstances to Features/OdsInstances/Manage, renaming all types/files to the OdsInstanceManage naming scheme and routes from /dbInstances to /odsInstances/manage.
…stanceManage query
…am.cs Task 2 already renamed JobConstants.CreatePendingDbInstancesDispatcherJobName and JobConstants.DeletePendingDbInstancesDispatcherJobName to their OdsInstanceManages equivalents. Program.cs's V3 branch still referenced the old member names on 4 lines, causing CS0117 errors when building EdFi.Ods.AdminApi.csproj standalone. JobConstants is shared (non-version- specific), so only the member names needed updating; the V3Jobs.* type references on the same lines correctly remain unchanged pending Task 13. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Moves and renames v2's DbInstances feature/command/query/dispatcher-job unit tests to match the OdsInstanceManage renames from Tasks 2-6, updates the in-place CreateInstanceJob/DeleteInstanceJob tests, and fixes references in the three Tenants-area test files (Task 5's amendment) plus ReadEducationOrganizationsTests.cs (an additional gap discovered while verifying the build, same class as the Tenants amendment).
Renames the integration-test files for AddDbInstance/DeleteDbInstance commands and GetDbInstance(s) queries to match the OdsInstanceManage production rename, and updates GetTenantEdOrgsByInstancesTests.cs in place to reference the renamed types.
The prior commit's git-add step aborted on stale pathspecs for the already-git-mv'd old filenames, leaving the index at the pre-rewrite snapshot. This commit stages the real working-tree content (renamed class/type names, OdsInstanceManage references) and includes GetTenantEdOrgsByInstancesTests.cs, which was missed entirely by the previous commit.
Renames v3's own Infrastructure layer (Queries, Commands, dispatcher Jobs) from DbDataStore-flavored names to DataStoreManage-flavored names, mirroring Task 3's v2 work. v3 uses DataStoreManage as its feature-layer naming convention while consuming the same shared OdsInstanceManage entity from Task 2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… /dataStores/manage Renames Features/DbDataStores (6 files) into a new Features/DataStores/Manage subfolder, updating class/interface names, namespace, and route paths from /dbDataStores to /dataStores/manage. Wires up to the OdsInstanceManage model and Task 10's Add/Get/Delete command and query interfaces.
…reManage query, add DataStoreManageId for v2 parity
Rename V3Jobs.CreatePendingDbInstancesDispatcherJob/DeletePendingDbInstancesDispatcherJob type references in Program.cs and the corresponding DI registrations in WebApplicationBuilderExtensions.cs to CreatePendingDataStoreManagesDispatcherJob/ DeletePendingDataStoreManagesDispatcherJob, completing the v3-side Quartz wiring rename.
…t coverage Task 14: renames DbDataStore-era v3 unit test files to match the DataStoreManage production types from Tasks 10-13, and adds GetDataStoreManagesQueryTests / GetDataStoreManageByIdQueryTests to close a pre-existing coverage gap (v3 never had query-level unit tests for this area).
Renames EdFi.Ods.AdminApi.V3.DBTests files and internal references from the legacy DbDataStore/DbInstance naming to the DataStoreManage/ OdsInstanceManage naming introduced by the production rename.
Mirrors Task 9's v2 rename. Moves and rewrites all 14 files under
Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DbDataStores
to v3/DataStores/Manage, updating meta.name, request URLs
(/v3/dbDataStores -> /v3/dataStores/manage), bru variable names
(CreatedDbDataStoreId -> CreatedDataStoreManageId, etc.), and test
assertion description strings. The not-found title assertion is updated
to check for "datastoremanage", matching the actual resource name
literal ("dataStoreManage") passed to NotFoundException in
ReadDataStoreManage.cs/DeleteDataStoreManage.cs.
… routes Updates request URLs from /v2/dbinstances to /v2/odsinstances/manage to match the renamed v2 endpoint, and renames @name block labels and their references accordingly. No v3/dbDataStores requests existed in this file.
Update three v2 Bruno E2E schema assertions to use the renamed odsInstanceManageId property instead of the old dbInstanceId name, and add the missing DataStoreManageId assertion to the v3 ReadEducationOrganizationsTests linked-instance test for parity with the equivalent v2 test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Test Results 15 files 15 suites 1m 6s ⏱️ Results for commit 9980586. ♻️ This comment has been updated with latest results. |
…s Manage E2E test
The route changed from /v2/dbinstances/{id} to /v2/odsinstances/manage/{id}
during the rename, adding a path segment. The old hardcoded
split("/")[2] pulled "manage" instead of the id, leaving
CreatedOdsInstanceManageId unset and breaking every downstream test that
depends on it. Switched to split("/").pop(), matching the pattern already
used by the Sample Template variant and by v3's equivalent test.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Documents the plan to add DataStoreManageId to v3's TenantDataStoreModel, closing a parity gap with v2's OdsInstanceManageId on the tenants/edOrgs endpoint. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Companion plan document for the design spec, executed via subagent-driven-development across Tasks 1-4. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates instance-management terminology and tenant/data-store response parity across v2 and v3, including adding the missing DataStoreManageId field to the v3 tenant .../dataStores/edOrgs response and renaming “DbInstances/DbDataStores” concepts to “OdsInstanceManage/DataStoreManage” throughout the API, background jobs, queries, and test suites.
Changes:
- Add
DataStoreManageIdto v3 tenant-leveldataStores/edOrgsresponse models/mapping, with corresponding unit/E2E schema updates. - Rename v2
/dbInstances→/odsInstances/manageand v3/dbDataStores→/dataStores/manage, including corresponding command/query/service/job updates. - Introduce DB rename scripts and update settings keys/constants to the new “OdsInstanceManages” naming.
Reviewed changes
Copilot reviewed 141 out of 142 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/superpowers/specs/2026-07-28-v3-tenant-datastore-manage-id-design.md | Design note documenting v3 tenant DataStoreManageId parity work and test updates. |
| docs/http/odsinstances-manage.http | Updates HTTP scratch file to new v2 /odsinstances/manage routes and request names. |
| Application/EdFi.Ods.AdminApi/Infrastructure/WebApplicationBuilderExtensions.cs | Updates Quartz DI registrations for renamed dispatcher jobs (v2) and v3 dispatcher job types. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Services/Tenants/TenantService.cs | Switch tenant edorg enrichment to use OdsInstanceManage query + populate OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Services/Jobs/DeletePendingOdsInstanceManagesDispatcherJob.cs | Renames/retargets delete dispatcher to OdsInstanceManages + updated status keys/job data keys. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Services/Jobs/DeleteInstanceJob.cs | Renames job data key and data access from DbInstances to OdsInstanceManages. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Services/Jobs/CreatePendingOdsInstanceManagesDispatcherJob.cs | Renames/retargets create dispatcher to OdsInstanceManages + updated status keys/job data keys. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Database/Queries/GetOdsInstanceManagesQuery.cs | Renames query interface/class and switches query to OdsInstanceManages DbSet. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Database/Queries/GetOdsInstanceManageByIdQuery.cs | Renames by-id query interface/class and switches to OdsInstanceManages DbSet. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Database/Commands/DeleteOdsInstanceManageCommand.cs | New delete command targeting OdsInstanceManages status transitions. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Database/Commands/DeleteDbInstanceCommand.cs | Removes old DbInstance delete command implementation. |
| Application/EdFi.Ods.AdminApi/Infrastructure/Database/Commands/AddOdsInstanceManageCommand.cs | Renames add command/model interface to OdsInstanceManage. |
| Application/EdFi.Ods.AdminApi/Infrastructure/AdminApiDbContext.cs | Renames DbInstances DbSet to OdsInstanceManages and updates table mapping. |
| Application/EdFi.Ods.AdminApi/Features/Tenants/TenantMapper.cs | Renames unlinked mapper to emit OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi/Features/Tenants/TenantDetailModel.cs | Renames tenant instance field DbInstanceId → OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi/Features/Tenants/ReadTenants.cs | Updates tenant edorg endpoint to inject IGetOdsInstanceManagesQuery. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/ReadEducationOrganizations.cs | Updates instance edorg endpoint to enrich using OdsInstanceManage query + fields. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/OdsInstanceWithEducationOrganizationsModel.cs | Renames response field DbInstanceId → OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/ReadOdsInstanceManage.cs | Renames/manage routes for v2 GET list/get-by-id from /dbInstances to /odsInstances/manage. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/OdsInstanceManageModel.cs | Renames the v2 manage model type and namespace for Swagger. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/OdsInstanceManageMapper.cs | Renames mapper to map OdsInstanceManage → OdsInstanceManageModel. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/OdsInstanceManageDatabaseNameFormatter.cs | Renames formatter type/namespace for new manage naming. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/DeleteOdsInstanceManage.cs | Renames v2 delete endpoint route and command/query dependencies to manage naming. |
| Application/EdFi.Ods.AdminApi/Features/OdsInstances/Manage/AddOdsInstanceManage.cs | Renames v2 post endpoint route, request model, validation, and scheduling keys. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/Tenants/GET - Tenants EdOrgs by Tenant Name - Singletenant.bru | Updates schema to expect odsInstanceManageId instead of dbInstanceId. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/Tenants/GET - Tenants EdOrgs by Tenant Name - Multitenant.bru | Updates schema to expect odsInstanceManageId instead of dbInstanceId. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/POST - OdsInstances Manage.bru | Updates POST route/name and variable names for new v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/POST - OdsInstances Manage - Sample Template.bru | Adds sample-template POST coverage for v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/POST - OdsInstances Manage - Invalid.bru | Updates invalid POST test to new v2 manage route and labels. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/POST - OdsInstances Manage - Invalid Database Template.bru | Updates invalid-template POST test to new v2 manage route and labels. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage.bru | Updates list GET test route/labels to new v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage by ID.bru | Updates get-by-id test to new v2 manage route and vars. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage - Without Offset.bru | Adds coverage for list GET without offset on new v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage - Without Limit.bru | Adds coverage for list GET without limit on new v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage - Without Limit and Offset.bru | Adds coverage for list GET without limit/offset on new v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage - Not Found.bru | Adds not-found GET coverage for v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/GET - OdsInstances Manage - Filter by Name.bru | Fixes filter-by-name GET route/labels to point at v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/folder.bru | Renames folder display name for new manage grouping. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/DELETE - OdsInstance Manage - Success.bru.disabled | Updates disabled delete scenario to new v2 manage route/vars. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/Manage/DELETE - OdsInstance Manage - Not Found.bru | Adds not-found DELETE coverage for v2 manage endpoint. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/OdsInstances/GET - OdsInstances - EdOrgs By InstanceId.bru | Updates schema field odsInstanceManageId for instance edorg response. |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/DbInstances/POST - DbInstances - Sample Template.bru | Removes old v2 dbinstances sample-template request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/DbInstances/GET - DbInstances - Without Offset.bru | Removes old v2 dbinstances “without offset” request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/DbInstances/GET - DbInstances - Without Limit and Offset.bru | Removes old v2 dbinstances “without limit/offset” request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/DbInstances/GET - DbInstances - Not Found.bru | Removes old v2 dbinstances not-found GET request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi/E2E Tests/V2/Bruno Admin API E2.0 refactor/v2/DbInstances/DELETE - DbInstance - Not Found.bru | Removes old v2 dbinstances not-found DELETE request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi/Artifacts/PgSql/Structure/Admin/00007-RenameDbInstancesToOdsInstanceManages.sql | Adds Postgres rename script for DbInstances → OdsInstanceManages. |
| Application/EdFi.Ods.AdminApi/Artifacts/MsSql/Structure/Admin/00007-RenameDbInstancesToOdsInstanceManages.sql | Adds SQL Server rename script for DbInstances → OdsInstanceManages. |
| Application/EdFi.Ods.AdminApi/appsettings.json | Renames create/delete dispatcher config keys to *OdsInstanceManages*. |
| Application/EdFi.Ods.AdminApi/appsettings.Development.json | Renames create/delete dispatcher config keys to *OdsInstanceManages* in dev settings. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Services/Tenants/TenantService.cs | Adds DataStoreManageId enrichment and renames injected manage query type. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Services/Jobs/DeletePendingDataStoreManagesDispatcherJob.cs | Renames v3 delete dispatcher job class/fields to DataStoreManage terminology. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Services/Jobs/DeleteInstanceJob.cs | Renames v3 delete worker job to use OdsInstanceManage id key and DbSet. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Services/Jobs/CreatePendingDataStoreManagesDispatcherJob.cs | Renames v3 create dispatcher job class/fields to DataStoreManage terminology. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Database/Queries/GetDataStoreManagesQuery.cs | Renames v3 list query interface/class to GetDataStoreManagesQuery. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Database/Queries/GetDataStoreManageByIdQuery.cs | Renames v3 by-id query interface/class to GetDataStoreManageByIdQuery. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Database/Commands/DeleteDataStoreManageCommand.cs | Renames v3 delete command interface/class to DataStoreManage terminology. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/Database/Commands/AddDataStoreManageCommand.cs | Renames v3 add command/model interface to DataStoreManage terminology. |
| Application/EdFi.Ods.AdminApi.V3/Infrastructure/AdminApiDbContext.cs | Renames v3 DbInstances DbSet to OdsInstanceManages and updates table mapping. |
| Application/EdFi.Ods.AdminApi.V3/Features/Tenants/TenantMapper.cs | Adds DataStoreManageId on unlinked entries via ToUnlinkedDataStoreManageModel. |
| Application/EdFi.Ods.AdminApi.V3/Features/Tenants/TenantDetailModel.cs | Adds DataStoreManageId to TenantDataStoreModel. |
| Application/EdFi.Ods.AdminApi.V3/Features/Tenants/ReadTenants.cs | Updates tenant edorg endpoint to inject IGetDataStoreManagesQuery. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/ReadEducationOrganizations.cs | Enriches datastore edorg response with DataStoreManageId and uses new query interface. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/ReadDataStoreManage.cs | Renames v3 manage list/get endpoints from /dbDataStores to /dataStores/manage. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/DeleteDataStoreManage.cs | Renames v3 delete endpoint route and dependencies to DataStoreManage terminology. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/DataStoreManageModel.cs | Renames v3 manage response model and namespace for Swagger. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/DataStoreManageMapper.cs | Renames v3 mapper to map OdsInstanceManage → DataStoreManageModel. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/DataStoreManageDatabaseNameFormatter.cs | Renames v3 formatter type/namespace for new manage naming. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/Manage/AddDataStoreManage.cs | Renames v3 post endpoint route, request model, validation, and scheduling keys. |
| Application/EdFi.Ods.AdminApi.V3/Features/DataStores/DataStoreWithEducationOrganizationsModel.cs | Adds DataStoreManageId to single-datastore edorg response model. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/Tenants/GET - Tenants EdOrgs by Tenant Name - Singletenant.bru | Updates v3 tenant edorg schema to include dataStoreManageId plus missing status/db fields. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/Tenants/GET - Tenants EdOrgs by Tenant Name - Multitenant.bru | Updates v3 tenant edorg schema to include dataStoreManageId plus missing status/db fields. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DbDataStores/POST - DbDataStores - Sample Template.bru | Removes old v3 dbDataStores sample-template request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DbDataStores/GET - DbDataStores - Without Limit.bru | Removes old v3 dbDataStores “without limit” request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DbDataStores/GET - DbDataStores - Without Limit and Offset.bru | Removes old v3 dbDataStores “without limit/offset” request (replaced by manage equivalents). |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/POST - DataStores Manage.bru | Updates POST route/name and variable names for new v3 manage endpoint. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/POST - DataStores Manage - Sample Template.bru | Adds sample-template POST coverage for v3 manage endpoint. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/POST - DataStores Manage - Invalid.bru | Updates invalid POST test to new v3 manage route and labels. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/POST - DataStores Manage - Invalid Database Template.bru | Updates invalid-template POST test to new v3 manage route and labels. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage.bru | Updates list GET test route/labels to new v3 manage endpoint. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage by ID.bru | Updates get-by-id test to new v3 manage route and vars. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage - Without Offset.bru | Updates list GET “without offset” request to new v3 manage route. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage - Without Limit.bru | Fixes list GET “without limit” request to new v3 manage route/version. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage - Without Limit and Offset.bru | Adds coverage for list GET without limit/offset on new v3 manage endpoint. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage - Not Found.bru | Updates not-found GET request/labels to new v3 manage route. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/GET - DataStores Manage - Filter by Name.bru | Fixes filter-by-name GET route/labels to point at v3 manage endpoint. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/folder.bru | Renames folder display name for new manage grouping. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/DELETE - DataStore Manage - Success.bru.disabled | Updates disabled delete scenario to new v3 manage route/vars. |
| Application/EdFi.Ods.AdminApi.V3/E2E Tests/Bruno Admin API E2E 3.0/v3/DataStores/Manage/DELETE - DataStore Manage - Not Found.bru | Updates not-found DELETE request/labels to new v3 manage route. |
| Application/EdFi.Ods.AdminApi.V3/Artifacts/PgSql/Structure/Admin/00007-RenameDbInstancesToOdsInstanceManages.sql | Adds Postgres rename script in v3 artifacts tree for DbInstances → OdsInstanceManages. |
| Application/EdFi.Ods.AdminApi.V3/Artifacts/MsSql/Structure/Admin/00007-RenameDbInstancesToOdsInstanceManages.sql | Adds SQL Server rename script in v3 artifacts tree for DbInstances → OdsInstanceManages. |
| Application/EdFi.Ods.AdminApi.V3/appsettings.json | Renames create/delete dispatcher config keys to *OdsInstanceManages* in v3 appsettings. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Infrastructure/Database/Queries/GetDataStoreManagesQueryTests.cs | Adds unit tests for renamed v3 list query. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Infrastructure/Database/Queries/GetDataStoreManageByIdQueryTests.cs | Adds unit tests for renamed v3 by-id query. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Infrastructure/Database/Commands/DeleteDataStoreManageCommandTests.cs | Updates tests for renamed v3 delete command and OdsInstanceManages DbSet. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Infrastructure/Database/Commands/AddDataStoreManageCommandTests.cs | Updates tests for renamed v3 add command and OdsInstanceManages DbSet. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Features/Tenants/TenantDetailModelTests.cs | Updates unit test to round-trip DataStoreManageId. |
| Application/EdFi.Ods.AdminApi.V3.UnitTests/Features/DataStores/ReadEducationOrganizationsTests.cs | Updates tests to use IGetDataStoreManagesQuery and assert DataStoreManageId. |
| Application/EdFi.Ods.AdminApi.V3.DBTests/Database/QueryTests/GetTenantEdOrgsByDataStoresTests.cs | Updates DBTests for renamed v3 query and model types. |
| Application/EdFi.Ods.AdminApi.V3.DBTests/Database/QueryTests/GetDataStoreManageByIdQueryTests.cs | Updates DBTests for renamed v3 by-id query. |
| Application/EdFi.Ods.AdminApi.V3.DBTests/Database/CommandTests/DeleteDataStoreManageCommandTests.cs | Updates DBTests for renamed v3 delete command and DbSet. |
| Application/EdFi.Ods.AdminApi.V3.DBTests/Database/CommandTests/AddDataStoreManageCommandTests.cs | Updates DBTests for renamed v3 add command and DbSet. |
| Application/EdFi.Ods.AdminApi.UnitTests/Infrastructure/Database/Queries/GetOdsInstanceManagesQueryTests.cs | Updates unit tests for renamed v2 list query and DbSet. |
| Application/EdFi.Ods.AdminApi.UnitTests/Infrastructure/Database/Queries/GetOdsInstanceManageByIdQueryTests.cs | Updates unit tests for renamed v2 by-id query and DbSet. |
| Application/EdFi.Ods.AdminApi.UnitTests/Infrastructure/Database/Commands/DeleteOdsInstanceManageCommandTests.cs | Updates unit tests for renamed v2 delete command and DbSet. |
| Application/EdFi.Ods.AdminApi.UnitTests/Infrastructure/Database/Commands/AddOdsInstanceManageCommandTests.cs | Updates unit tests for renamed v2 add command and DbSet. |
| Application/EdFi.Ods.AdminApi.UnitTests/Features/Tenants/TenantDetailModelTests.cs | Updates unit test to round-trip OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi.UnitTests/Features/OdsInstances/ReadEducationOrganizationsTests.cs | Updates tests to use IGetOdsInstanceManagesQuery and assert OdsInstanceManageId. |
| Application/EdFi.Ods.AdminApi.DBTests/Database/QueryTests/GetTenantEdOrgsByInstancesTests.cs | Updates DBTests for renamed v2 query and model types. |
| Application/EdFi.Ods.AdminApi.DBTests/Database/QueryTests/GetOdsInstanceManageByIdQueryTests.cs | Updates DBTests for renamed v2 by-id query. |
| Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/DeleteOdsInstanceManageCommandTests.cs | Updates DBTests for renamed v2 delete command and DbSet. |
| Application/EdFi.Ods.AdminApi.DBTests/Database/CommandTests/AddOdsInstanceManageCommandTests.cs | Updates DBTests for renamed v2 add command and DbSet. |
| Application/EdFi.Ods.AdminApi.Common/Settings/AppSettings.cs | Renames dispatcher cadence/retry properties to *OdsInstanceManages*. |
| Application/EdFi.Ods.AdminApi.Common/Infrastructure/Models/OdsInstanceManage.cs | Renames the entity model from DbInstance to OdsInstanceManage. |
| Application/EdFi.Ods.AdminApi.Common/Infrastructure/Jobs/JobConstants.cs | Renames job-data key and dispatcher job name constants to manage naming. |
| Application/EdFi.Ods.AdminApi.Common/Constants/Constants.cs | Renames DbInstanceStatus enum to OdsInstanceManageStatus. |
Comments suppressed due to low confidence (1)
docs/http/odsinstances-manage.http:51
- This file defines
# @name createOdsInstanceManageMinimaltwice (the earlier create request and this later one). Many REST client runners treat duplicated@nameas an override, which can make the subsequent DELETE/GET requests refer to the unintended response.
DavidJGapCR
changed the title
DavidJGapCR
marked this pull request as ready for review
July 28, 2026 21:40
…ments 1 & 3) docs/developer.md's "DbInstance Provisioning Jobs" section still documented the pre-rename route, table name, and config keys, plus a dead link to a design doc deleted back in 73c77cf (predates this rename) — repointed to design/INSTANCE-MANAGEMENT-Quartz.md, which is the actual current home for that content (job identities, retry strategy, Mermaid diagrams). TenantServiceTests.cs:284 had a leftover "DbInstance2" fixture display name (never asserted by value) — renamed to match the OdsInstanceManage naming and the sibling "Instance2" fixture pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jagudelo-gap
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.