[MC-1] Restore POC-3 test suite (rename-adapted) + tests/lint CI#12
Open
touchdownllc wants to merge 1 commit into
Open
[MC-1] Restore POC-3 test suite (rename-adapted) + tests/lint CI#12touchdownllc wants to merge 1 commit into
touchdownllc wants to merge 1 commit into
Conversation
Port of tests/ from POC-3 main (f69f38a) — dropped by the MC-1 migration — adapted to this repo's renames so it runs against src/ directly: - module refs: poc3.* -> src.*; conftest shadow-install guard repointed - identifier renames mirrored: poc3_tier/adj/justification/in_scope -> mc_*, no_poc3_row -> no_mc_row, build_poc3_lookup/reviewer_key_to_poc3_key -> *_mc_*, _POC3_HEADERS/_POC3_ROOT -> _MC_*, *_with_poc3_scores.xlsx -> *_with_mc_scores.xlsx (goldens included) - expected CLI strings: `poc3 <cmd>` -> `mc <cmd>` - test_readme_cli_drift.py omitted: it pins the POC-3 README's CLI section, which this repo's README does not carry Status on MC-1 (2dc386d): 2,201 passed / 19 failed / 1 skipped with -m "not realdata". The failures are review findings, not port noise: 13x run_all requires ANTHROPIC_API_KEY up front (runner.py:360), 3x extract/peer_gap.AnthropicClient monkeypatch seam removed, 2x workbook fingerprint drift from the rename (goldens need regeneration), 1x bundled AZ workbook absent (data/bootstrap/ gitignored and not shipped). The lint lane also surfaces 2 pre-existing mypy errors in azure_client.py. tests.yml is POC-3's workflow with comments updated for this repo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #11 — merge this into
MC-1to restore the POC-3 test suite and CI that the initial migration left behind. One commit; merges clean on the currentMC-1head.What's in it
tests/ported from POC-3 main (f69f38a), adapted to this repo's renames:poc3.*→src.*module refs,poc3_*→mc_*identifiers and artifact keys (goldens included), expected CLI stringspoc3 <cmd>→mc <cmd>, conftest shadow-install guard repointed.test_readme_cli_drift.pyis omitted — it pins the POC-3 README's CLI section, which this repo's README doesn't carry..github/workflows/tests.yml— POC-3's workflow (Ubuntu + Windows pytest lanes, ruff + mypy lint lane) with comments updated.Current status on
MC-1: 2,201 passed / 19 failed / 1 skipped (-m "not realdata"). The failures are not port noise — they map 1:1 to the findings in the PR #11 review: 13×run_allrequiringANTHROPIC_API_KEYup front, 3× the removedAnthropicClientmonkeypatch seam inextract/peer_gap, 2× workbook-fingerprint drift from the rename, 1× the absent bundled AZ workbook. The lint lane also surfaces two mypy errors inazure_client.py. The suite goes green as those are fixed.🤖 Generated with Claude Code