EDFI-2786 Generalize Account Management link, remove Keycloak fallback - #214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Admin App v4’s frontend “Account Management” link behavior to support non-Keycloak identity providers by removing the hardcoded Keycloak fallback URL and only showing the link when an IdP account URL is explicitly configured.
Changes:
- Removed the Keycloak localhost fallback and sourced
IDP_ACCOUNT_URLsolely fromconfig.idpAccountUrl. - Updated the Account page to conditionally render the “Account Management” section only when
IDP_ACCOUNT_URLis present. - Updated the example frontend environment file to document
VITE_IDP_ACCOUNT_URLas optional and IdP-specific.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fe/src/app/Pages/Account/ViewAccount.tsx | Hides the “Account Management” UI when no IdP account URL is configured to avoid broken links. |
| packages/fe/src/app/api/methods.ts | Removes the hardcoded Keycloak fallback and makes IDP_ACCOUNT_URL optional (config-driven only). |
| packages/fe/.copyme.env.local | Documents VITE_IDP_ACCOUNT_URL as optional with example values for multiple IdPs and notes that leaving it unset hides the link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
analiliagutierrez
force-pushed
the
EDFI-2786-generalize-account-management-link
branch
from
July 2, 2026 16:54
0a4beca to
d277b7a
Compare
analiliagutierrez
marked this pull request as ready for review
July 2, 2026 16:57
Merged
6 tasks
analiliagutierrez
force-pushed
the
EDFI-2786-generalize-account-management-link
branch
from
July 28, 2026 17:48
d277b7a to
e66a14f
Compare
analiliagutierrez
force-pushed
the
EDFI-2786-generalize-account-management-link
branch
2 times, most recently
from
August 10, 2026 23:51
ba2a2b6 to
e33587f
Compare
Drop the hardcoded Keycloak account URL fallback in methods.ts so IDP_ACCOUNT_URL is undefined when VITE_IDP_ACCOUNT_URL is unset. Hide the Account Management link in ViewAccount when no URL is configured, avoiding a broken link for non-Keycloak IdPs (e.g. Entra). Clean the env template to document the variable as optional and IdP-specific. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
analiliagutierrez
force-pushed
the
EDFI-2786-generalize-account-management-link
branch
from
August 11, 2026 15:30
e33587f to
919fbe4
Compare
jagudelo-gap
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the hardcoded Keycloak fallback for the frontend "Account Management" link in Admin App v4. The link's URL now comes solely from
VITE_IDP_ACCOUNT_URL; when that value is not configured, the link is hidden instead of pointing users to an invalid Keycloak URL. This enables correct behavior for the newly supported non-Keycloak identity providers (e.g. Entra ID, Google Workspace).Ticket
EDFI-2786 — Generalize the Account Management link (remove hardcoded Keycloak fallback)
Type of Change
What Changed
packages/fe/src/app/api/methods.ts—IDP_ACCOUNT_URLis nowstring | undefinedsourced directly fromconfig.idpAccountUrl; the hardcodedhttps://localhost/auth/realms/edfi/account/fallback is removed.packages/fe/src/app/Pages/Account/ViewAccount.tsx— the "Account Management" section renders only whenIDP_ACCOUNT_URLis set, so no broken link appears when the variable is unset.packages/fe/.copyme.env.local— replaces the Keycloak example value with a comment documentingVITE_IDP_ACCOUNT_URLas optional and IdP-specific (Entra / Google / Keycloak examples), noting that leaving it unset hides the link.Testing
Manual
The frontend was built and deployed over a local IIS install (
https://localhost/adminapp/) and exercised with a real OIDC login (Entra ID):nx run fe:build, base/adminapp/) and deploy it to the install.VITE_IDP_ACCOUNT_URL=https://myaccount.microsoft.com/(runtimeconfig.js), log in, navigate to/account.VITE_IDP_ACCOUNT_URL, reload/account.Follow-Up
Setting
VITE_IDP_ACCOUNT_URLcorrectly per deployment is covered by EDFI-2774; this PR only changes the frontend behavior when the value is absent.Checklist