Skip to content

ECWID-172634: Add a new field in OrderForCalculate to check if the request came from Order Editor. #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ECWID-172634: Add a new field in OrderForCalculate to check if the request came from Order Editor. #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91c0600
Merge remote-tracking branch 'origin/master'
VHripsime Sep 19, 2025
50fd1c8
ECWID-172634: Add a new field in OrderForCalculate to check if the re…
VHripsime Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/cart/request/OrderForCalculate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ data class OrderForCalculate(
val giftCardRedemption: Double? = null,
val totalBeforeGiftCardRedemption: Double? = null,
val giftCardDoubleSpending: Boolean? = null,
val fromOE: Boolean? = false,
Copy link
Contributor

@zont163 zont163 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а нам точно нужно такое поле? По appId мы не можем определить, что запрос пришел именно от OE?

Copy link
Contributor

@qblake qblake Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и что скрывается под этим полем? это ж публичное апи. вдруг кто-то еще захочет воспользоваться этим полем? как они поймут что им нужно именно оно?
скорее всего название поля должно отражать суть того, как оно повлияет на результаты расчета.

Copy link
Contributor Author

@VHripsime VHripsime Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, посмотрела, внутри запроса уже приходит имя app-а. Так что закрою этот ПР.

) : ApiRequestDTO {

data class DiscountInfo(
Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/OrderForCalculateRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ val orderForCalculateNullablePropertyRules: List<NullablePropertyRule<*, *>> = l
AllowNullable(OrderForCalculate::taxAlreadyDeductedFromShipping),
AllowNullable(OrderForCalculate::shippingOption),
IgnoreNullable(OrderForCalculate::shippingPerson),
AllowNullable(OrderForCalculate::fromOE),
AllowNullable(OrderForCalculate.CustomSurcharge::description),
AllowNullable(OrderForCalculate.CustomSurcharge::id),
AllowNullable(OrderForCalculate.CustomSurcharge::taxable),
Expand Down