-
Notifications
You must be signed in to change notification settings - Fork 13
ECWID-161269 - add a new modified RequestKind to replace ApiCredentials #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArAkAru
wants to merge
8
commits into
master
Choose a base branch
from
ECWID-161269
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
66903ab
ECWID-161269 - add a new modified RequestKind to replace ApiCredentials
ArAkAru 97886a1
ECWID-161269 - fix addition value to map
ArAkAru 6e73cbb
ECWID-161269 - delete url from general info in profile
ArAkAru 55b0e8e
ECWID-161269 - delete storeId from buildBaseEndpointPath
ArAkAru 812da36
ECWID-161269 - made the field `credentials` temporarily optional
ArAkAru 33f6dc6
ECWID-161269 - set default value
ArAkAru 1453861
ECWID-161269 - add default null value to public constructor
ArAkAru 3df038b
ECWID-161269 - delete RequestKind implementations
ArAkAru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package com.ecwid.apiclient.v3.config | ||
|
||
abstract class RequestKind { | ||
abstract fun buildBaseEndpointPath(): String | ||
abstract fun buildHeaders(): Map<String, String> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,9 +70,7 @@ abstract class BaseEntityTest { | |
|
||
protected fun initStoreProfile() { | ||
val expectedProfile = UpdatedStoreProfile( | ||
generalInfo = UpdatedStoreProfile.GeneralInfo( | ||
storeUrl = "" | ||
), | ||
generalInfo = UpdatedStoreProfile.GeneralInfo(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this thing breaks the behavior in tests because the platform is not |
||
formatsAndUnits = UpdatedStoreProfile.FormatsAndUnits( | ||
orderNumberPrefix = "", | ||
orderNumberSuffix = "" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
requestKind
is provided, we use all data from it; otherwise, we use the old data fromcredentials
.all this
if
block will be deleted soon